From 2fad5446cd941770002b83a6b6d8e5f2acd36b2b Mon Sep 17 00:00:00 2001 From: "D. Ror." Date: Mon, 3 Feb 2025 14:08:14 -0500 Subject: [PATCH] [ReviewEntries] Add error text when saving empty sense (#3593) --- public/locales/en/translation.json | 1 + .../ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/public/locales/en/translation.json b/public/locales/en/translation.json index c62b3aedfe..ad6b99cb1e 100644 --- a/public/locales/en/translation.json +++ b/public/locales/en/translation.json @@ -335,6 +335,7 @@ "error": { "gloss": "Glosses cannot be left blank", "glossAndDefinition": "Glosses and definitions cannot both be left blank", + "sense": "Cannot save an empty sense", "senses": "Cannot save an entry with no senses", "vernacular": "Vernacular cannot be left blank" }, diff --git a/src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx b/src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx index 60186fc43b..dd51195960 100644 --- a/src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx +++ b/src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx @@ -145,7 +145,7 @@ export default function EditSenseDialog( // Confirm nonempty senses const cleanedSense = cleanSense(newSense, { definitionsEnabled }); if (!cleanedSense || typeof cleanedSense === "string") { - toast.error(t(cleanedSense ?? "")); + toast.error(t(cleanedSense || "reviewEntries.error.sense")); return; }