[MergeDups] Toast when actions fail

Author: imnasnainaec

public/locales/en/translation.json

@@ -417,7 +417,9 @@
       "protectedSenseInfo": "This sense cannot be deleted or dropped into another sense. You may still move it to another word or drop other senses into this one to merge them.",
       "protectedWord": "This word was imported with data that The Combine doesn't handle.",
       "protectedWordInfo": "To prevent deletion, the final sense of this word cannot be removed.",
-      "protectedData": "Protected data: {{ val }}"
+      "protectedData": "Protected data: {{ val }}",
+      "dropIntoSidebarWarning": "You cannot drop senses into the sidebar.",
+      "dropProtectedSenseWarning": "You cannot merge a protected sense into another sense."
     },
     "protectReason": {
       "annotations": "annotations",

src/goals/MergeDuplicates/MergeDupsStep/MergeDragDrop/index.tsx

@@ -3,6 +3,7 @@ import { Drawer, Grid, ImageList, ImageListItem, Tooltip } from "@mui/material";
 import { CSSProperties, ReactElement, useState } from "react";
 import { DragDropContext, Droppable, DropResult } from "react-beautiful-dnd";
 import { useTranslation } from "react-i18next";
+import { toast } from "react-toastify";
 import { v4 } from "uuid";
 
 import { appBarHeight } from "components/AppBar/AppBarTypes";
@@ -63,20 +64,22 @@ export default function MergeDragDrop(): ReactElement {
       setSrcToDelete(src);
     } else if (res.combine) {
       // Case 2: the sense was dropped on another sense.
+      const dest: MergeTreeReference = JSON.parse(res.combine.draggableId);
+      if (dest.order !== undefined) {
+        // Case 2a: If the target is a sidebar sub-sense, it cannot receive a combine.
+        toast.warning(t("mergeDups.helpText.dropIntoSidebarWarning"));
+        return;
+      }
       if (src.isSenseProtected && !src.order) {
-        // Case 2a: Cannot merge a protected sense into another sense.
+        // Case 2b: Cannot merge a protected sense into another sense.
+        toast.warning(t("mergeDups.helpText.dropProtectedSenseWarning"));
         const destWordId = res.combine.droppableId;
         if (srcWordId !== destWordId) {
           // The target sense is in a different word, so move instead of combine.
           dispatch(moveSense({ destOrder: 0, destWordId, src }));
         }
         return;
       }
-      const dest: MergeTreeReference = JSON.parse(res.combine.draggableId);
-      if (dest.order !== undefined) {
-        // Case 2b: If the target is a sidebar sub-sense, it cannot receive a combine.
-        return;
-      }
       const combinePayload: CombineSenseMergePayload = { dest, src };
       dispatch(combineSense(combinePayload));
     } else if (res.destination) {
@@ -87,18 +90,21 @@ export default function MergeDragDrop(): ReactElement {
         // Case 3a: The source, dest droppables are different.
         if (destWordId.split(" ").length > 1) {
           // If the destination is SidebarDrop, it cannot receive drags from elsewhere.
+          toast.warning(t("mergeDups.helpText.dropIntoSidebarWarning"));
           return;
         }
         // Move the sense to the dest MergeWord.
         const movePayload: MoveSensePayload = { destOrder, destWordId, src };
         dispatch(moveSense(movePayload));
       } else {
         // Case 3b: The source & dest droppables are the same, so we reorder, not move.
-        if (
-          src.order === destOrder ||
-          (destOrder === 0 && src.order !== undefined && sidebarProtected)
-        ) {
-          // If the sense wasn't moved or was moved within the sidebar above a protected sense, do nothing.
+        if (src.order === destOrder) {
+          // If the sense wasn't moved, do nothing.
+          return;
+        }
+        const toTop = destOrder === 0 && src.order !== undefined;
+        if (toTop && sidebarProtected) {
+          // If the sense was moved within the sidebar above a protected sense, do nothing.
           return;
         }
         const orderPayload: OrderSensePayload = { destOrder, src };