CR feedback

Author: FyreByrd

src/lib/components/BookTabs.svelte

@@ -4,15 +4,7 @@ A component that displays the book tabs and allows the user to switch between th
 -->
 <script lang="ts">
     import { scriptureConfig } from '$assets/config';
-    import {
-        convertStyle,
-        language,
-        languageDefault,
-        monoIconColor,
-        refs,
-        s,
-        theme
-    } from '$lib/data/stores';
+    import { convertStyle, language, monoIconColor, refs, s, theme } from '$lib/data/stores';
 
     const tabIcons = import.meta.glob('./*', {
         import: 'default',
@@ -31,13 +23,10 @@ A component that displays the book tabs and allows the user to switch between th
         refs.setBookTab(newTab);
     }
     function getImageName(tabType?: string) {
-        return (tabType && scriptureConfig.tabTypes?.[tabType]?.images?.[0].file) || '';
+        return (tabType && scriptureConfig.tabTypes?.[tabType]?.images?.[0]?.file) || '';
     }
     function getTabTypeName(tabType?: string) {
-        return (
-            scriptureConfig.tabTypes?.[tabType ?? '']?.name?.[$language] ||
-            scriptureConfig.tabTypes?.[tabType ?? '']?.name?.[$language]
-        );
+        return scriptureConfig.tabTypes?.[tabType ?? '']?.name?.[$language];
     }
 </script>
 

src/lib/components/BottomNavigationBar.svelte

@@ -4,7 +4,7 @@
 <script lang="ts">
     import config, { scriptureConfig } from '$assets/config';
     import contents from '$assets/contents';
-    import { language, languageDefault, refs, s, theme } from '$lib/data/stores';
+    import { language, refs, s, theme } from '$lib/data/stores';
     import { gotoRoute } from '$lib/navigate';
 
     const menuIcons = import.meta.glob('./*', {
@@ -135,7 +135,7 @@
                             <picture class:invert={$theme === 'Dark'}>
                                 <!-- Image Icon -->
                                 <img
-                                    src={menuIcons[`./${item.images?.[0].file}`]}
+                                    src={menuIcons[`./${item.images?.[0]?.file}`]}
                                     alt=""
                                     class={selectedLink(item.type, item.link?.['default'])
                                         ? 'opacity-100'
@@ -149,7 +149,7 @@
                                     ? barTextSelectedColor
                                     : barTextColor}"
                             >
-                                {item.title[$language] || item.title[$language]}
+                                {item.title[$language]}
                             </span>
                         </button>
                     {/if}

src/lib/components/ContentSingle.svelte

@@ -7,7 +7,7 @@
         item: ContentItem;
         imageFolder: string;
         onClick?: (target: HTMLElement, item: ContentItem) => void;
-        checkImageSize?: (item: ContentItem) => void;
+        checkImageSize?: (item: ContentItem) => string;
         features?: FeatureConfig;
     }
 
@@ -25,6 +25,7 @@
 
     function checkImageSizeFallback(item: ContentItem) {
         console.warn('USING checkImageSizeFallback');
+        return '';
     }
 
     function renderLastTextBox(layout?: FeatureValue): boolean {

src/lib/components/FontSelector.svelte

@@ -29,12 +29,10 @@ Font Selector component.
 <Modal bind:this={modal} id={modalId}>
     <FontList bind:this={fontList} selectedFont={$currentFont ?? ''} />
     <div class="flex w-full justify-between dy-modal-action">
-        <!-- svelte-ignore a11y-click-events-have-key-events -->
         <button
             style={convertStyle($s?.['ui.dialog.button'])}
             class="dy-btn dy-btn-sm dy-btn-ghost no-animation">{$t['Button_Cancel']}</button
         >
-        <!-- svelte-ignore a11y-click-events-have-key-events -->
         <button
             style={convertStyle($s?.['ui.dialog.button'])}
             class="dy-btn dy-btn-sm dy-btn-ghost no-animation"

src/lib/components/SearchResultList.svelte

@@ -24,7 +24,8 @@
     // Changes to signal when to clear results
     const showSpinner = $derived(!queryDone && results.length === 0);
     let resultsShown = $state<SearchResult[]>([]);
-    let displayQueryId = $derived(queryId);
+    // svelte-ignore state_referenced_locally
+    let displayQueryId = $state(queryId);
 
     const resultCountText = $derived(formatResultCount(results.length));
 

src/lib/components/Settings.svelte

@@ -16,7 +16,7 @@
     );
 </script>
 
-<!--Interfacerough the different settings types -->
+<!-- loops through the different settings types -->
 {#each Object.keys(categories) as category}
     <div class="settings-category">
         {$t[category]}

src/lib/components/Sidebar.svelte

@@ -15,7 +15,6 @@ The sidebar/drawer.
         isDAB,
         isSAB,
         language,
-        languageDefault,
         modal,
         ModalType,
         refs,
@@ -88,7 +87,7 @@ The sidebar/drawer.
     );
 
     function imageSrcSet(images: MenuItemConfig['images']) {
-        const baseSize = Number(images?.[0].width);
+        const baseSize = Number(images?.[0]?.width);
         return images
             ?.map((image) => {
                 const size = Number(image.width);
@@ -266,12 +265,12 @@ The sidebar/drawer.
                                     <source srcset={imageSrcSet(item.images)} />
                                 {/if}
                                 <img
-                                    src={menuIcons[`./${item.images?.[0].file}`] ?? ''}
+                                    src={menuIcons[`./${item.images?.[0]?.file}`] ?? ''}
                                     height="24"
                                     width="24"
-                                    alt={item.title[$language] || item.title[languageDefault]}
+                                    alt={item.title[$language]}
                                 />
-                            </picture>{item.title[$language] || item.title[languageDefault]}
+                            </picture>{item.title[$language]}
                         </a>
                     </li>
                 {/each}

src/lib/components/TabsMenu.svelte

@@ -37,7 +37,7 @@ A component to display tabbed menus.
         }
         active = tab;
     };
-    const ActiveComponent = $derived(options[active].snippet);
+    const ActiveComponent = $derived(options[active]?.snippet);
 </script>
 
 {#if hasTabs}

src/routes/notes/edit/[noteid]/+page.svelte

@@ -15,7 +15,8 @@
     let textarea: HTMLTextAreaElement | undefined = $state();
     const note = $derived(data.note);
     const isNew = $derived(note ? false : true);
-    let text = $derived(note?.text ?? '');
+    // svelte-ignore state_referenced_locally
+    let text = $state(note?.text ?? '');
     const reference = $derived(note?.reference ?? $selectedVerses[0]?.reference);
     const title = $derived(isNew ? 'Annotation_Note_Add' : 'Annotation_Note_Edit');