Fix typing issue in tests for QuotationMarkUpdateFirstPass

Ben King · Ben King · commit 7e7d577f1ad4 · 2025-07-17T11:14:27.000-04:00
diff --git a/tests/corpora/test_quotation_mark_update_first_pass.py b/tests/corpora/test_quotation_mark_update_first_pass.py
@@ -334,54 +334,54 @@ def test_choose_best_action_based_on_observed_issues() -> None:
     first_pass_analyzer._will_fallback_mode_work = False
 
     # Test with no issues
-    best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues([])
+    best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues(set())
     assert best_action == QuotationMarkUpdateStrategy.APPLY_FULL
 
     # Test with one issue
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK]
+            {QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK}
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK]
+            {QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK}
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [QuotationMarkResolutionIssue.TOO_DEEP_NESTING]
+            {QuotationMarkResolutionIssue.TOO_DEEP_NESTING}
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
 
     # Test with multiple issues
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [
+            {
                 QuotationMarkResolutionIssue.TOO_DEEP_NESTING,
                 QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,
-            ]
+            }
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [
+            {
                 QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,
                 QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,
-            ]
+            }
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [
+            {
                 QuotationMarkResolutionIssue.TOO_DEEP_NESTING,
                 QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,
-            ]
+            }
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
@@ -392,54 +392,54 @@ def test_choose_best_action_based_on_observed_issues_with_basic_fallback() -> No
     first_pass_analyzer._will_fallback_mode_work = True
 
     # Test with no issues
-    best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues([])
+    best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues(set())
     assert best_action == QuotationMarkUpdateStrategy.APPLY_FULL
 
     # Test with one issue
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK]
+            {QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK}
         )
         == QuotationMarkUpdateStrategy.APPLY_FALLBACK
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK]
+            {QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK}
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [QuotationMarkResolutionIssue.TOO_DEEP_NESTING]
+            {QuotationMarkResolutionIssue.TOO_DEEP_NESTING}
         )
         == QuotationMarkUpdateStrategy.APPLY_FALLBACK
     )
 
     # Test with multiple issues
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [
+            {
                 QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,
                 QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,
-            ]
+            }
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [
+            {
                 QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,
                 QuotationMarkResolutionIssue.TOO_DEEP_NESTING,
-            ]
+            }
         )
         == QuotationMarkUpdateStrategy.SKIP
     )
     assert (
         first_pass_analyzer._choose_best_strategy_based_on_observed_issues(
-            [
+            {
                 QuotationMarkResolutionIssue.TOO_DEEP_NESTING,
                 QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,
-            ]
+            }
         )
         == QuotationMarkUpdateStrategy.APPLY_FALLBACK
     )

Original file line number	Diff line number	Diff line change
`@@ -334,54 +334,54 @@ def test_choose_best_action_based_on_observed_issues() -> None:`
`334`	`334`	`first_pass_analyzer._will_fallback_mode_work = False`
`335`	`335`
`336`	`336`	`# Test with no issues`
`337`		`- best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues([])`
	`337`	`+ best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues(set())`
`338`	`338`	`assert best_action == QuotationMarkUpdateStrategy.APPLY_FULL`
`339`	`339`
`340`	`340`	`# Test with one issue`
`341`	`341`	`assert (`
`342`	`342`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`343`		`- [QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK]`
	`343`	`+ {QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK}`
`344`	`344`	`)`
`345`	`345`	`== QuotationMarkUpdateStrategy.SKIP`
`346`	`346`	`)`
`347`	`347`	`assert (`
`348`	`348`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`349`		`- [QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK]`
	`349`	`+ {QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK}`
`350`	`350`	`)`
`351`	`351`	`== QuotationMarkUpdateStrategy.SKIP`
`352`	`352`	`)`
`353`	`353`	`assert (`
`354`	`354`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`355`		`- [QuotationMarkResolutionIssue.TOO_DEEP_NESTING]`
	`355`	`+ {QuotationMarkResolutionIssue.TOO_DEEP_NESTING}`
`356`	`356`	`)`
`357`	`357`	`== QuotationMarkUpdateStrategy.SKIP`
`358`	`358`	`)`
`359`	`359`
`360`	`360`	`# Test with multiple issues`
`361`	`361`	`assert (`
`362`	`362`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`363`		`- [`
	`363`	`+ {`
`364`	`364`	`QuotationMarkResolutionIssue.TOO_DEEP_NESTING,`
`365`	`365`	`QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,`
`366`		`- ]`
	`366`	`+ }`
`367`	`367`	`)`
`368`	`368`	`== QuotationMarkUpdateStrategy.SKIP`
`369`	`369`	`)`
`370`	`370`	`assert (`
`371`	`371`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`372`		`- [`
	`372`	`+ {`
`373`	`373`	`QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,`
`374`	`374`	`QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,`
`375`		`- ]`
	`375`	`+ }`
`376`	`376`	`)`
`377`	`377`	`== QuotationMarkUpdateStrategy.SKIP`
`378`	`378`	`)`
`379`	`379`	`assert (`
`380`	`380`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`381`		`- [`
	`381`	`+ {`
`382`	`382`	`QuotationMarkResolutionIssue.TOO_DEEP_NESTING,`
`383`	`383`	`QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,`
`384`		`- ]`
	`384`	`+ }`
`385`	`385`	`)`
`386`	`386`	`== QuotationMarkUpdateStrategy.SKIP`
`387`	`387`	`)`
`@@ -392,54 +392,54 @@ def test_choose_best_action_based_on_observed_issues_with_basic_fallback() -> No`
`392`	`392`	`first_pass_analyzer._will_fallback_mode_work = True`
`393`	`393`
`394`	`394`	`# Test with no issues`
`395`		`- best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues([])`
	`395`	`+ best_action = first_pass_analyzer._choose_best_strategy_based_on_observed_issues(set())`
`396`	`396`	`assert best_action == QuotationMarkUpdateStrategy.APPLY_FULL`
`397`	`397`
`398`	`398`	`# Test with one issue`
`399`	`399`	`assert (`
`400`	`400`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`401`		`- [QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK]`
	`401`	`+ {QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK}`
`402`	`402`	`)`
`403`	`403`	`== QuotationMarkUpdateStrategy.APPLY_FALLBACK`
`404`	`404`	`)`
`405`	`405`	`assert (`
`406`	`406`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`407`		`- [QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK]`
	`407`	`+ {QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK}`
`408`	`408`	`)`
`409`	`409`	`== QuotationMarkUpdateStrategy.SKIP`
`410`	`410`	`)`
`411`	`411`	`assert (`
`412`	`412`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`413`		`- [QuotationMarkResolutionIssue.TOO_DEEP_NESTING]`
	`413`	`+ {QuotationMarkResolutionIssue.TOO_DEEP_NESTING}`
`414`	`414`	`)`
`415`	`415`	`== QuotationMarkUpdateStrategy.APPLY_FALLBACK`
`416`	`416`	`)`
`417`	`417`
`418`	`418`	`# Test with multiple issues`
`419`	`419`	`assert (`
`420`	`420`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`421`		`- [`
	`421`	`+ {`
`422`	`422`	`QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,`
`423`	`423`	`QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,`
`424`		`- ]`
	`424`	`+ }`
`425`	`425`	`)`
`426`	`426`	`== QuotationMarkUpdateStrategy.SKIP`
`427`	`427`	`)`
`428`	`428`	`assert (`
`429`	`429`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`430`		`- [`
	`430`	`+ {`
`431`	`431`	`QuotationMarkResolutionIssue.AMBIGUOUS_QUOTATION_MARK,`
`432`	`432`	`QuotationMarkResolutionIssue.TOO_DEEP_NESTING,`
`433`		`- ]`
	`433`	`+ }`
`434`	`434`	`)`
`435`	`435`	`== QuotationMarkUpdateStrategy.SKIP`
`436`	`436`	`)`
`437`	`437`	`assert (`
`438`	`438`	`first_pass_analyzer._choose_best_strategy_based_on_observed_issues(`
`439`		`- [`
	`439`	`+ {`
`440`	`440`	`QuotationMarkResolutionIssue.TOO_DEEP_NESTING,`
`441`	`441`	`QuotationMarkResolutionIssue.UNPAIRED_QUOTATION_MARK,`
`442`		`- ]`
	`442`	`+ }`
`443`	`443`	`)`
`444`	`444`	`== QuotationMarkUpdateStrategy.APPLY_FALLBACK`
`445`	`445`	`)`