Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NParallelTextCorpus #159

Open
Enkidu93 opened this issue Feb 26, 2025 · 2 comments
Open

Implement NParallelTextCorpus #159

Enkidu93 opened this issue Feb 26, 2025 · 2 comments

Comments

@Enkidu93
Copy link
Collaborator

Enkidu93 commented Feb 26, 2025 •
edited
Loading

Since NParallelTextCorpus in Machine (C#) now backs the implementation for ParallelTextCorpus.GetRows() which undergirds text alignment, this is particularly important.
@Enkidu93 Enkidu93 added this to Serval Feb 26, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Feb 26, 2025
@johnml1135
Copy link
Collaborator

Is this to align SILNLP's mixed source with Serval's? It makes sense - I just want to understand the relative priority.

@Enkidu93
Copy link
Collaborator Author

Is this to align SILNLP's mixed source with Serval's? It makes sense - I just want to understand the relative priority.

I don't know where all SILNLP uses machine.py's ParallelTextCorpus and where it might have its own logic (that might be worth a closer look; probably Matthew would know), but yes, that's the general idea.

@johnml1135 johnml1135 moved this from 🆕 New to 📋 Backlog in Serval Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Serval
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnml1135 @Enkidu93