Skip to content

Commit 1e5f87b

Browse files
authored
Get rid of symfony-exceptions.patch (#1815)
* Get rid of symfony-exceptions.patch We can finally get rid of this since it seems PHP exceptions are finally deriving from the Exception class rather than the Error class. * Simply comment out the appropriate Dockerfile lines This way we can easily re-apply the patch if need be. Also comment the commented-out lines so it's clear why they exist.
1 parent 0194f27 commit 1e5f87b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

docker/app/Dockerfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ RUN chown -R www-data:www-data /var/www/html/assets /var/www/html/cache \
7676

7777
COPY --from=composer-builder /composer/vendor /var/www/html/vendor
7878

79-
# patch exception handling from Symfony to actually show exceptions instead of swallowing them
80-
COPY docker/app/symfony-exceptions.patch /
81-
RUN patch -p4 -i /symfony-exceptions.patch
79+
# Uncomment the two lines below if you see Symfony errors like "expected Exception, got Error instead"
80+
# This will allow you to see the actual underlying error, rather than the Symfony exception that hides the underlying one
81+
# COPY docker/app/symfony-exceptions.patch /
82+
# RUN patch -p4 -i /symfony-exceptions.patch
8283

8384
RUN echo "${BUILD_VERSION}" > build-version.txt \
8485
&& sed -i "s/9.9.9/${BUILD_VERSION}/" version.php

0 commit comments

Comments
 (0)