From 11018f05fbb63c24da3e5f687c45346a2dece29a Mon Sep 17 00:00:00 2001 From: Christopher Hirt Date: Thu, 2 May 2024 16:27:35 +0700 Subject: [PATCH 1/4] remove obsolete docker compose version see https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-obsolete for more information --- docker-compose.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/docker-compose.yml b/docker-compose.yml index 564f409200..3c64e90012 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -1,6 +1,5 @@ # https://docs.docker.com/compose/compose-file # https://github.com/compose-spec/compose-spec/blob/master/spec.md -version: '3.5' # networks: # lexbox: From baaecc30c965f6594c0081ab09afbcbe49727c15 Mon Sep 17 00:00:00 2001 From: Christopher Hirt Date: Thu, 2 May 2024 16:30:13 +0700 Subject: [PATCH 2/4] update DEVELOPER docs PHP 7.4 ref update references to PHP 7.4 --- docs/DEVELOPER.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/DEVELOPER.md b/docs/DEVELOPER.md index 7d045f9b57..62fccefb14 100644 --- a/docs/DEVELOPER.md +++ b/docs/DEVELOPER.md @@ -38,7 +38,7 @@ On Windows, the project should be opened with the [Remote - WSL](https://marketp While Docker is great way to encapsulate all of the dependencies, build tools and run-time environment of the application, IDEs usually require locally installed extensions, tools and runtimes in order to provide type checking, code hints, and debugging capabilities that make for a better developer experience. To this end, the following locally installed tools/dependencies may be installed for good DX: -- PHP 7.3 +- PHP 7.4 - Composer - Node and npm - .Net SDK From db1565577f310df00be9e0ca3b72b249c9990e1f Mon Sep 17 00:00:00 2001 From: Christopher Hirt Date: Thu, 2 May 2024 16:39:48 +0700 Subject: [PATCH 3/4] remove WSL recommendation remove WSL recommendation in DEVELOPER docs we run on straight Windows now --- docs/DEVELOPER.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/DEVELOPER.md b/docs/DEVELOPER.md index 62fccefb14..c065ec17f6 100644 --- a/docs/DEVELOPER.md +++ b/docs/DEVELOPER.md @@ -30,9 +30,7 @@ Welcome! We're glad that you are interested in helping develop Language Forge. ### Supported Development Environments -Development of Language Forge is supported using [VS Code](https://code.visualstudio.com/download) on Linux, MacOS or Windows using WSL ([`wsl --install`](https://learn.microsoft.com/en-us/windows/wsl/install)). - -On Windows, the project should be opened with the [Remote - WSL](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-wsl) VS Code extension, so that all commands and extensions run on WSL. +Development of Language Forge is supported using [VS Code](https://code.visualstudio.com/download) on Linux, MacOS or Windows ### IDE Developer Experience (DX) From 0e767e247f69a1bfe18e142c209b25ec98745173 Mon Sep 17 00:00:00 2001 From: Christopher Hirt Date: Fri, 3 May 2024 15:14:09 +0700 Subject: [PATCH 4/4] update docs to node 22 --- docs/DEVELOPER.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/DEVELOPER.md b/docs/DEVELOPER.md index c065ec17f6..93e675dc46 100644 --- a/docs/DEVELOPER.md +++ b/docs/DEVELOPER.md @@ -50,9 +50,8 @@ While Docker is great way to encapsulate all of the dependencies, build tools an 2. Permit your user (and not just "sudo") to contact the Docker daemon: `sudo usermod -aG docker yourUsername && sudo chmod 666 /var/run/docker.sock`. 3. (Optional) Configure docker to start on boot: `printf '[boot]\ncommand="service docker start"\n' | sudo tee /etc/wsl.conf` (assuming `/etc/wsl.conf` is currently unused). 2. Install [Make](https://www.gnu.org/software/make/): `sudo apt install make`. -3. Install [Node 16.14.0](https://nodejs.org/en/download/). We recommend using [nvm](https://github.com/nvm-sh/nvm#installation-and-update). +3. Install [Node 22](https://nodejs.org/en/download/). We recommend using [nvm](https://github.com/nvm-sh/nvm#installation-and-update) or [nvm on Windows](https://github.com/coreybutler/nvm-windows). 4. Clone the repo: `git clone https://github.com/sillsdev/web-languageforge`. - 1. Windows users, be sure to clone the project to the WSL file system (to keep VS Code, Git and the file system in sync) 5. Run `npm install` (required for git pre-commit hook with Prettier) ### Running the App Locally