Skip to content

Commit fc89363

Browse files
authored
Check if the release is converted from the tag when updating the release (go-gitea#30984)
Call `notify_service.NewRelease` when a release is created from an existing tag.
1 parent d0d6aad commit fc89363

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

services/release/release.go

+8-2
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ func UpdateRelease(ctx context.Context, doer *user_model.User, gitRepo *git.Repo
204204
if rel.ID == 0 {
205205
return errors.New("UpdateRelease only accepts an exist release")
206206
}
207-
isCreated, err := createTag(gitRepo.Ctx, gitRepo, rel, "")
207+
isTagCreated, err := createTag(gitRepo.Ctx, gitRepo, rel, "")
208208
if err != nil {
209209
return err
210210
}
@@ -216,6 +216,12 @@ func UpdateRelease(ctx context.Context, doer *user_model.User, gitRepo *git.Repo
216216
}
217217
defer committer.Close()
218218

219+
oldRelease, err := repo_model.GetReleaseByID(ctx, rel.ID)
220+
if err != nil {
221+
return err
222+
}
223+
isConvertedFromTag := oldRelease.IsTag && !rel.IsTag
224+
219225
if err = repo_model.UpdateRelease(ctx, rel); err != nil {
220226
return err
221227
}
@@ -292,7 +298,7 @@ func UpdateRelease(ctx context.Context, doer *user_model.User, gitRepo *git.Repo
292298
}
293299

294300
if !rel.IsDraft {
295-
if !isCreated {
301+
if !isTagCreated && !isConvertedFromTag {
296302
notify_service.UpdateRelease(gitRepo.Ctx, doer, rel)
297303
return nil
298304
}

0 commit comments

Comments
 (0)