Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support window.history #150

Open
dbendaou opened this issue Mar 20, 2020 · 1 comment
Open

Support window.history #150

dbendaou opened this issue Mar 20, 2020 · 1 comment

Comments

@dbendaou
Copy link

Hi,
Either I've miss something or not, but the README doesn't make any mention of window.history

I was trying to test my back button that basically does window.history.back() but my test was still returning to the previous page 😅

In the controller that contain the goBack function I've added
import window from 'ember-window-mock';

and in the test I've added both
import { setupWindowMock } from 'ember-window-mock';
and
setupWindowMock(hooks);

Is this out of scope to support things like that with history or should I do it another way ?

Thanks for your help

@simonihmig
Copy link
Owner

It is basically a missing feature! 🙂

Keeping this here as a feature request. But not sure if I am able to implement this in the foreseeable future. PRs certainly welcome...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants