Add support for HTTP POST method on authorization endpoint (#242)

* Add support for HTTP POST method on authorization endpoint

* Update request rules so to check request params based on HTTP methods

* Change namespace for request rules

* Get rid of GetClientFromRequestTrait

---------

Co-authored-by: Marko Ivančić <[email protected]>

Author: cicnavi

UPGRADE.md

@@ -26,6 +26,7 @@
     - `consent` and `preprodwarning` are two authprocs that redirect for user interaction and are now supported
   - Uses SSP's ProcessingChain class for closer alignment with SAML IdP configuration.
     - Allows additional configuration of authprocs in the main `config.php` under key `authproc.oidc`
+- Authorization endpoint now also supports sending parameters using HTTP POST method, in addition to GET.
 
 ## New configuration options
 
@@ -73,6 +74,8 @@ has been refactored:
 - upgraded to v5 of lcobucci/jwt https://github.com/lcobucci/jwt
 - upgraded to v3 of laminas/laminas-diactoros https://github.com/laminas/laminas-diactoros
 - SimpleSAMLphp version used during development was bumped to v2.2
+- In Authorization Code Flow, a new validation was added which checks for 'openid' value in 'scope' parameter. Up to
+now, 'openid' value was dynamically added if not present. In Implicit Code Flow this validation was already present. 
 
 # Version 4 to 5
 

routing/routes/routes.php

@@ -6,7 +6,6 @@
 
 declare(strict_types=1);
 
-use SimpleSAML\Module\oidc\Codebooks\HttpMethodsEnum;
 use SimpleSAML\Module\oidc\Codebooks\RoutesEnum;
 use SimpleSAML\Module\oidc\Controller\AccessTokenController;
 use SimpleSAML\Module\oidc\Controller\AuthorizationController;
@@ -15,6 +14,7 @@
 use SimpleSAML\Module\oidc\Controller\Federation\EntityStatementController;
 use SimpleSAML\Module\oidc\Controller\JwksController;
 use SimpleSAML\Module\oidc\Controller\UserInfoController;
+use SimpleSAML\OpenID\Codebooks\HttpMethodsEnum;
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
 
 /** @psalm-suppress InvalidArgument */

routing/services/services.yml

@@ -36,8 +36,9 @@ services:
     resource: '../../src/Bridges/*'
 
   SimpleSAML\Module\oidc\ModuleConfig: ~
+  SimpleSAML\Module\oidc\Helpers: ~
   SimpleSAML\Module\oidc\Forms\Controls\CsrfProtection: ~
-  SimpleSAML\Module\oidc\Utils\Checker\RequestRulesManager:
+  SimpleSAML\Module\oidc\Server\RequestRules\RequestRulesManager:
     factory: ['@SimpleSAML\Module\oidc\Factories\RequestRulesManagerFactory', 'build']
   # Grants
   SimpleSAML\Module\oidc\Server\Grants\AuthCodeGrant: