Skip to content

Commit 5c05922

Browse files
authored
fixing bug that writing package file defaults to None (#582)
* fixing bug that writing package file defaults to None * undo changed registry path Signed-off-by: vsoch <[email protected]>
1 parent ce1452d commit 5c05922

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
1414
The versions coincide with releases on pip. Only major versions will be released as tags on Github.
1515

1616
## [0.0.x](https://github.com/singularityhub/singularity-hpc/tree/main) (0.0.x)
17+
- Fixing bug with writing package file in update (0.1.1)
1718
- Add support for remote registry and sync commands --all (0.1.0)
1819
- support for GitLab and GitHub remotes
1920
- fixing bug to config set/get nested fields, default for wrapper scripts true (0.0.57)

shpc/main/registry/filesystem.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def save(self, package_file):
4949
"""
5050
Save the new package file to container.yaml
5151
"""
52+
package_file = package_file or self.package_file
5253
shpc.utils.write_yaml(self._config, package_file)
5354

5455
def load_wrapper_script(self, container_tech, script):

shpc/settings.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,4 +103,4 @@ container_features:
103103
# defaults to ~/.Xauthority if set to true and the container has x11: true
104104
home: # one of null, or a single path or src:dest path.
105105
# home: true in a container.yaml will use this path, if defines
106-
updated_at: '2022-08-20T16:40:24Z'
106+
updated_at: '2022-08-26T20:38:06Z'

shpc/tests/test_wrappers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ def test_get_local_template_paths(tmp_path, with_custom_wrapper_template_path):
3939
registry.FilesystemResult("quay.io/vgteam/vg", container_yaml)
4040
)
4141
ws = wrappers_base.WrapperScript(
42-
"dummy.sh", # Not used in this test
42+
"dummy.sh",
4343
client.settings,
4444
config=config,
45-
image=None,
45+
image=None, # Not used in this test
4646
)
4747
client.settings.set(
4848
"wrapper_scripts",

shpc/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
__copyright__ = "Copyright 2021-2022, Vanessa Sochat"
33
__license__ = "MPL 2.0"
44

5-
__version__ = "0.1.0"
5+
__version__ = "0.1.1"
66
AUTHOR = "Vanessa Sochat"
77
NAME = "singularity-hpc"
88
PACKAGE_URL = "https://github.com/singularityhub/singularity-hpc"

0 commit comments

Comments
 (0)