Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the change of k in fixed_threshold #450

Open
sarahmish opened this issue Aug 26, 2023 · 0 comments
Open

Allow the change of k in fixed_threshold #450

sarahmish opened this issue Aug 26, 2023 · 0 comments
Labels
enhancement Improvements on the current features

Comments

@sarahmish
Copy link
Collaborator

def _fixed_threshold(errors, k=4):

Currently, fixed threshold is always set on k=4 which makes the threshold set on four standard deviations away from the mean. We would like to make k dynamic and changeable.

Proposal:

  • if fixed_threshold is False, go to dynamic thresholding
  • if fixed_threshold is True, make the fixed threshold set to a default which is k=4
  • if fixed_threshold is an int or float, make this an indication on how far away from the mean it should be
@sarahmish sarahmish added the enhancement Improvements on the current features label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements on the current features
Projects
None yet
Development

No branches or pull requests

1 participant