Skip to content

Commit 9f4e6ee

Browse files
committed
Run just "sdist", not "build sdist" in the publush job to make sure
no garbage gets included into sdist. Rename stuff for clarity.
1 parent 88e0d39 commit 9f4e6ee

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

.github/workflows/build_and_test.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ permissions:
2323

2424
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
2525
jobs:
26-
build_and_test_python:
26+
build_test_python:
27+
name: 'Build&Test: Python'
2728
strategy:
2829
fail-fast: false
2930
matrix:
@@ -62,7 +63,7 @@ jobs:
6263
shell: bash
6364

6465
- name: build
65-
run: CC=${COMPILER} LDSHARED="${COMPILER} -shared" python setup.py build sdist
66+
run: CC=${COMPILER} LDSHARED="${COMPILER} -shared" python setup.py sdist build
6667
shell: bash
6768

6869
# - if: ${{ matrix.os == 'windows' }} && ${{ matrix.python-version == '3.10' }}
@@ -89,12 +90,14 @@ jobs:
8990
shell: bash
9091

9192
build_wheels:
93+
name: Build Python Wheels
9294
permissions:
9395
packages: write
94-
needs: build_and_test_python
96+
needs: build_test_python
9597
uses: sippy/cimagic/.github/workflows/BuildPythonWheels.yml@v1
9698

9799
publish_all_wheels:
100+
name: Publish Python Wheels
98101
runs-on: ubuntu-latest
99102
needs: build_wheels
100103
environment:
@@ -125,7 +128,7 @@ jobs:
125128
pip install --upgrade build setuptools wheel
126129
127130
- name: build
128-
run: python setup.py build sdist
131+
run: python setup.py sdist
129132

130133
- name: Check release version number
131134
if: github.event_name == 'release' && github.event.action == 'published'
@@ -139,6 +142,7 @@ jobs:
139142
uses: pypa/gh-action-pypi-publish@release/v1
140143

141144
roll_release:
145+
name: Release
142146
needs: publish_all_wheels
143147
permissions:
144148
contents: write

0 commit comments

Comments
 (0)