Init passByRefFunctionsCache to null explicitly

sirbrillig · sirbrillig · commit fb9f3b61bfb5 · 2025-03-16T19:02:10.000-04:00
diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php
@@ -156,9 +156,9 @@ class VariableAnalysisSniff implements Sniff
 	/**
 	 * A cache for getPassByReferenceFunctions
 	 *
-	 * @var array<array<int|string>>
+	 * @var array<array<int|string>>|null
 	 */
-	private $passByRefFunctionsCache;
+	private $passByRefFunctionsCache = null;
 
 	public function __construct()
 	{
@@ -211,7 +211,7 @@ private function getPassByReferenceFunction($functionName)
 	 */
 	private function getPassByReferenceFunctions()
 	{
-		if (isset($this->passByRefFunctionsCache)) {
+		if (! is_null($this->passByRefFunctionsCache)) {
 			return $this->passByRefFunctionsCache;
 		}
 		$passByRefFunctions = Constants::getPassByReferenceFunctions();

Original file line number	Diff line number	Diff line change
`@@ -156,9 +156,9 @@ class VariableAnalysisSniff implements Sniff`
`156`	`156`	`/**`
`157`	`157`	`* A cache for getPassByReferenceFunctions`
`158`	`158`	`*`
`159`		`- * @var array<array<int\|string>>`
	`159`	`+ * @var array<array<int\|string>>\|null`
`160`	`160`	`*/`
`161`		`- private $passByRefFunctionsCache;`
	`161`	`+ private $passByRefFunctionsCache = null;`
`162`	`162`
`163`	`163`	`public function __construct()`
`164`	`164`	`{`
`@@ -211,7 +211,7 @@ private function getPassByReferenceFunction($functionName)`
`211`	`211`	`*/`
`212`	`212`	`private function getPassByReferenceFunctions()`
`213`	`213`	`{`
`214`		`- if (isset($this->passByRefFunctionsCache)) {`
	`214`	`+ if (! is_null($this->passByRefFunctionsCache)) {`
`215`	`215`	`return $this->passByRefFunctionsCache;`
`216`	`216`	`}`
`217`	`217`	`$passByRefFunctions = Constants::getPassByReferenceFunctions();`