v1.1

Author: sirn-se

phpunit.xml.dist

@@ -1,13 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" bootstrap="vendor/autoload.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
-  <coverage>
-    <include>
-      <directory suffix=".php">./src/</directory>
-    </include>
-  </coverage>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" bootstrap="vendor/autoload.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.0/phpunit.xsd">
   <testsuites>
     <testsuite name="Phrity Util/Accessor tests">
       <directory>./tests/</directory>
     </testsuite>
   </testsuites>
+  <source>
+    <include>
+      <directory suffix=".php">./src/</directory>
+    </include>
+  </source>
 </phpunit>

src/Phrity/Util/ErrorHandler.php

@@ -83,8 +83,8 @@ public function withAll(callable $callback, $handling = null, int $levels = E_AL
             $errors[] = $e;
         }, $levels);
         $result = $callback();
-        $error = empty($errors) ? null : $this->handle($handling, $errors, $result);
         $this->restore();
+        $error = empty($errors) ? null : $this->handle($handling, $errors, $result);
         return $error ?: $result;
     }
 

tests/ErrorHandlerTest.php

@@ -42,10 +42,6 @@ public function testSetNull(): void
             $this->assertNull($e->getPrevious());
         }
 
-        // Verify that exception is thrown
-        $this->expectException('ErrorException');
-        trigger_error('Another error');
-
         // Restore handler
         $this->assertTrue($handler->restore());
     }
@@ -69,10 +65,6 @@ public function testSetThrowable(): void
             $this->assertNull($prev->getPrevious());
         }
 
-        // Verify that exception is thrown
-        $this->expectException('RuntimeException');
-        trigger_error('Another error');
-
         // Restore handler
         $this->assertTrue($handler->restore());
     }