fix: wrong error handling in router invoker

Author: CypherPotato

src/Http/HttpStatusInformation.cs

@@ -100,7 +100,7 @@ private static void ValidateDescription ( string s ) {
         /// <param name="statusCode">The HTTP status code.</param>
         /// <returns>The description of the HTTP status code.</returns>
         public static string GetStatusCodeDescription ( int statusCode ) {
-            return HttpStatusDescription.Get ( statusCode );
+            return HttpStatusDescription.Get ( statusCode ) ?? "Unknown";
         }
 
         /// <summary>

src/Http/Streams/HttpWebSocket.cs

@@ -299,8 +299,10 @@ private bool SendInternal ( ReadOnlyMemory<byte> buffer, WebSocketMessageType ms
 
                     ReadOnlyMemory<byte> chunk = buffer [ ca..cb ];
 
-                    ctx.WebSocket.SendAsync ( chunk, msgType, i + 1 == chunks, CancellationToken.None )
-                        .AsTask ().Wait ();
+                    var sendVt = ctx.WebSocket.SendAsync ( chunk, msgType, i + 1 == chunks, asyncListenerToken?.Token ?? default );
+                    if (!sendVt.IsCompleted) {
+                        sendVt.AsTask ().GetAwaiter ().GetResult ();
+                    }
 
                     length += chunk.Length;
                 }

src/Internal/HttpStatusDescription.cs

@@ -12,15 +12,11 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Net;
-
 namespace Sisk.Core.Internal;
 
 static class HttpStatusDescription {
-    internal static string? Get ( HttpStatusCode code ) =>
-        Get ( (int) code );
 
-    internal static string Get ( int code ) =>
+    internal static string? Get ( int code ) =>
         code switch {
             100 => "Continue",
             101 => "Switching Protocols",
@@ -88,6 +84,6 @@ internal static string Get ( int code ) =>
             510 => "Not Extended",
             511 => "Network Authentication Required",
 
-            _ => "Unknown"
+            _ => null
         };
 }

src/Routing/Router.Invoker.cs

@@ -173,17 +173,25 @@ internal RouterExecutionResult Execute ( HttpContext context ) {
             }
         }
 
-        if (matchResult == RouteMatchResult.NotMatched && NotFoundErrorHandler is not null) {
-            return new RouterExecutionResult ( NotFoundErrorHandler ( context ), null, matchResult, null );
+        if (matchResult == RouteMatchResult.NotMatched) {
+            if (NotFoundErrorHandler is not null) {
+                return new RouterExecutionResult ( NotFoundErrorHandler ( context ), null, matchResult, null );
+            }
+            else {
+                return new RouterExecutionResult ( new HttpResponse ( HttpStatusCode.NotFound ), null, matchResult, null );
+            }
         }
         else if (matchResult == RouteMatchResult.OptionsMatched) {
-            HttpResponse corsResponse = new HttpResponse ();
-
-            return new RouterExecutionResult ( corsResponse, null, matchResult, null );
+            return new RouterExecutionResult ( new HttpResponse ( HttpStatusCode.OK ), null, matchResult, null );
         }
-        else if (matchResult == RouteMatchResult.PathMatched && MethodNotAllowedErrorHandler is not null) {
+        else if (matchResult == RouteMatchResult.PathMatched) {
             context.MatchedRoute = matchedRoute;
-            return new RouterExecutionResult ( MethodNotAllowedErrorHandler ( context ), matchedRoute, matchResult, null );
+            if (MethodNotAllowedErrorHandler is not null) {
+                return new RouterExecutionResult ( MethodNotAllowedErrorHandler ( context ), matchedRoute, matchResult, null );
+            }
+            else {
+                return new RouterExecutionResult ( new HttpResponse ( HttpStatusCode.MethodNotAllowed ), matchedRoute, matchResult, null );
+            }
         }
         else if (matchResult == RouteMatchResult.FullyMatched && matchedRoute is not null) {
             context.MatchedRoute = matchedRoute;

src/Sisk.Core.csproj

@@ -49,7 +49,7 @@
 	<PropertyGroup>
 		<AssemblyVersion>1.4.1</AssemblyVersion>
 		<FileVersion>1.4.1</FileVersion>
-		<Version>1.4.1</Version>
+		<Version>1.4.1-beta1</Version>
 	</PropertyGroup>
 
 	<!-- licensing, readme, signing -->