dump v1.6

Author: CypherPotato

cadente/Sisk.Cadente.CoreEngine/Sisk.Cadente.CoreEngine.csproj

@@ -47,7 +47,7 @@
 	<PropertyGroup>
 		<AssemblyVersion>1.6.0</AssemblyVersion>
 		<FileVersion>1.6.0</FileVersion>
-		<Version>1.6.0-beta8</Version>
+		<Version>1.6.0-beta9</Version>
 	</PropertyGroup>
 
 	<!-- licensing, readme, signing -->

cadente/Sisk.Cadente/HttpSerializer/HttpRequestReader.cs

@@ -60,10 +60,6 @@ static class HttpRequestReader {
                     Logger.LogInformation ( $"failed to parse HTTP request: connection closed" );
                     return null;
                 }
-                if (bytesRead == 0) {
-                    // Connection closed by client before sending complete headers
-                    return null;
-                }
 
                 totalRead += bytesRead;
 

cadente/Sisk.Cadente/Logger.cs

@@ -17,8 +17,10 @@ static class Logger {
     [Conditional ( "DEBUG" )]
     [MethodImpl ( MethodImplOptions.AggressiveInlining )]
     public static void LogInformation ( ref DefaultInterpolatedStringHandler message ) {
+#if DEBUG
         // Note: Connection ID logging is only available in DEBUG builds and may be uninitialized.
-        var connectionId = HttpConnection.Id.Value != 0 ? HttpConnection.Id.Value.ToString() : "N/A";
+        var connectionId = HttpConnection.Id.Value != 0 ? HttpConnection.Id.Value.ToString () : "N/A";
         Console.WriteLine ( $"Sisk.ManagedHttpListener [{DateTime.Now:R}] [CON {connectionId}] {message.ToString ()}" );
+#endif
     }
 }

cadente/Sisk.Cadente/Sisk.Cadente.csproj

@@ -47,7 +47,7 @@
 	<PropertyGroup>
 		<AssemblyVersion>1.0</AssemblyVersion>
 		<FileVersion>1.0</FileVersion>
-		<Version>1.0-beta8</Version>
+		<Version>1.0-beta9</Version>
 	</PropertyGroup>
 
 	<!-- licensing, readme, signing -->

cadente/benchmark/Program.cs

@@ -0,0 +1,17 @@
+using Sisk.Cadente;
+
+var host = new HttpHost ( 5555 ) {
+    UsePipelines = false  // Disable pipelines for testing
+};
+
+host.UseHandler ( async ctx => {
+    ctx.Response.StatusCode = 200;
+    ctx.Response.Headers.Set ( new HttpHeader ( "Content-Length", "13" ) );
+    using var stream = await ctx.Response.GetResponseStreamAsync ( chunked: false );
+    await stream.WriteAsync ( "Hello, World!"u8.ToArray () );
+} );
+
+host.Start ();
+Console.WriteLine ( $"Server listening on http://localhost:5555" );
+Console.WriteLine ( "Press Ctrl+C to stop..." );
+Thread.Sleep ( -1 );

cadente/benchmark/benchmark.csproj

@@ -0,0 +1,14 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net10.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\Sisk.Cadente\Sisk.Cadente.csproj" />
+  </ItemGroup>
+
+</Project>

src/Helpers/PathHelper.cs

@@ -15,6 +15,30 @@ namespace Sisk.Core.Helpers;
 /// Provides useful path-dedicated helper members.
 /// </summary>
 public sealed class PathHelper {
+
+    static readonly char [] forbiddenPathChars = Path.GetInvalidPathChars ();
+    static readonly char [] forbiddenFileChars = Path.GetInvalidFileNameChars ();
+
+    /// <summary>
+    /// Determines whether the specified path contains only valid path and file-name characters.
+    /// </summary>
+    /// <param name="path">The path to validate.</param>
+    /// <returns>
+    /// <see langword="true"/> if <paramref name="path"/> contains no invalid path or file-name characters;
+    /// otherwise, <see langword="false"/>.
+    /// </returns>
+    public static bool IsPathAllowed ( string path ) {
+        string filePart = Path.GetFileName ( path );
+
+        if (filePart.IndexOfAny ( forbiddenFileChars ) >= 0)
+            return false;
+
+        if (path.IndexOfAny ( forbiddenPathChars ) >= 0)
+            return false;
+
+        return true;
+    }
+
     /// <summary>
     /// Splits the specified path into its individual segments, removing empty entries and trimming whitespace.
     /// </summary>

src/Http/BrotliContent.cs

@@ -1,4 +1,4 @@
-// The Sisk Framework source code
+// The Sisk Framework source code
 // Copyright (c) 2024- PROJECT PRINCIPIUM and all Sisk contributors
 //
 // The code below is licensed under the MIT license as

src/Http/LogStream.cs

@@ -7,9 +7,11 @@
 // File name:   LogStream.cs
 // Repository:  https://github.com/sisk-http/core
 
+using System.Globalization;
 using System.Text;
 using System.Threading.Channels;
 using Sisk.Core.Entity;
+using Sisk.Core.Helpers;
 
 namespace Sisk.Core.Http {
     /// <summary>
@@ -37,6 +39,22 @@ public class LogStream : IDisposable, IAsyncDisposable {
         private static readonly Lazy<LogStream> _consoleOutputLazy = new Lazy<LogStream> ( () => new LogStream ( Console.Out ) );
         private static readonly Lazy<LogStream> _emptyLazy = new Lazy<LogStream> ( () => new LogStream () );
 
+        /// <summary>
+        /// Converts the specified <see cref="DateTime"/> to a file-name-safe string representation
+        /// formatted as "yyyy-MM-dd_HH-mm-ss".
+        /// </summary>
+        /// <param name="dt">The date and time to convert.</param>
+        /// <param name="provider">An object that supplies culture-specific formatting information. Can be <see langword="null"/>.</param>
+        /// <returns>A string that is safe for use in file names.</returns>
+        public static string EscapeSafeDateTime ( DateTime dt, IFormatProvider? provider = null ) {
+            return dt.ToString ( "yyyy-MM-dd_HH-mm-ss", provider );
+        }
+
+        /// <summary>
+        /// Gets the current local date and time as a file-name-safe string formatted as "yyyy-MM-dd_HH-mm-ss".
+        /// </summary>
+        public static string SafeTimestamp => EscapeSafeDateTime ( DateTime.Now, CultureInfo.InvariantCulture );
+
         /// <summary>
         /// Gets a shared <see cref="LogStream"/> that writes its output to the <see cref="Console.Out"/> stream.
         /// </summary>
@@ -86,6 +104,10 @@ public string? FilePath {
                 if (value is not null) {
                     _filePath = Path.GetFullPath ( value );
 
+                    if (!PathHelper.IsPathAllowed ( _filePath )) {
+                        throw new ArgumentException ( SR.Format ( SR.LogStream_InvalidFilePath, value ), nameof ( value ) );
+                    }
+
                     string? dirPath = Path.GetDirectoryName ( _filePath );
                     if (dirPath is not null)
                         Directory.CreateDirectory ( dirPath );

src/Internal/SR.cs

@@ -64,6 +64,7 @@ static partial class SR {
     public const string LogStream_RotatingLogPolicy_NotLocalFile = "Cannot link an rotaging log policy to an log stream which ins't pointing to an local file.";
     public const string LogStream_RotatingLogPolicy_AlreadyBind = "The specified LogStream is already binded to another RotatingLogPolicy.";
     public const string LogStream_RotatingLogPolicy_IntervalZero = "The RotatingLogPolicy interval must be greater than zero.";
+    public const string LogStream_InvalidFilePath = "Invalid file path specified for the LogStream: '{0}'";
 
     public const string HttpRequestEventSource_KeepAliveDisposed = "Cannot keep alive an instance that has it's connection disposed.";