Skip to content

Commit e56e5d5

Browse files
sjahrmarioprats
andauthored
Apply suggestions from code review
Co-authored-by: Mario Prats <[email protected]>
1 parent 6552aa3 commit e56e5d5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

moveit_core/robot_model/include/moveit/robot_model/joint_model_group.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ class JointModelGroup
587587
std::vector<size_t>& joint_bijection) const;
588588

589589
/**
590-
* @brief Get the lower and upper position limits of a given joint group.
590+
* @brief Get the lower and upper position limits of all active variables in the group.
591591
*
592592
* @return std::pair<Eigen::VectorXd, Eigen::VectorXd> Containing the joint limits
593593
*/
@@ -596,7 +596,7 @@ class JointModelGroup
596596
/**
597597
* @brief Gets the pair of maximum joint velocities/accelerations for a given group. Asserts that the group contains
598598
* only single-variable joints,
599-
*
599+
* @details In case of asymmetric velocity or acceleration limits, this function will return the most limiting component.
600600
* @return std::pair<Eigen::VectorXd, Eigen::VectorXd> Containing the velocity and acceleration limits
601601
*/
602602
[[nodiscard]] std::pair<Eigen::VectorXd, Eigen::VectorXd> getMaxVelocitiesAndAccelerationBounds() const;

moveit_core/robot_model/src/joint_model_group.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -858,7 +858,7 @@ std::pair<Eigen::VectorXd, Eigen::VectorXd> JointModelGroup::getMaxVelocitiesAnd
858858
{
859859
// TODO(sjahr) Support multiple variables
860860
RCLCPP_ERROR(getLogger(), "Number of active joint models does not match number of active joint model bounds. "
861-
"Returning bound vectors.with zeros");
861+
"Returning bound vectors with zeros");
862862
return { max_joint_velocities, max_joint_accelerations };
863863
}
864864
for (std::size_t i = 0; i < active_joint_models_bounds_.size(); ++i)

0 commit comments

Comments
 (0)