Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profile to be set via system property as an alternative #11

Open
neowulf opened this issue Mar 23, 2017 · 1 comment
Open

Allow profile to be set via system property as an alternative #11

neowulf opened this issue Mar 23, 2017 · 1 comment

Comments

@neowulf
Copy link
Contributor

neowulf commented Mar 23, 2017

Although, it's nice to execute:

AWS_DEFAULT_PROFILE="sandbox" sbt ecr:createRepository

it'd be nice to have an alternative to execute:

sbt -Daws.profile=sandbox ecr:createRepository

This also has a nice property that the build can be configured via the initialize sbt task which prevents for users to specify the profile by default if not found.

initialize ~= { _ =>
  System.setProperty("aws.profile", sys.props.getOrElse("aws.profile", "sandbox"))
}
@sjednac
Copy link
Owner

sjednac commented Mar 25, 2017

This could be a nice extension indeed. The main issue I'm seeing are priorities for the config - we should probably keep the same order as in the authentication chain.

I'll do some research on the existing conventions and I'll get back to you. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants