Skip to content

Commit 0db6460

Browse files
sjoshidsjoshid
sjoshid
authored and
sjoshid
committed
1) Handling NPE
1 parent 1d1bdea commit 0db6460

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/main/java/org/influxdb/impl/InfluxDBResultMapper.java

+6-9
Original file line numberDiff line numberDiff line change
@@ -333,9 +333,6 @@ <T> void setFieldValue(final T object, final Field field, final Method fieldSett
333333
if (!field.isAccessible()) {
334334
field.setAccessible(true);
335335
}
336-
if (!fieldSetter.isAccessible()) {
337-
fieldSetter.setAccessible(true);
338-
}
339336
if (assignInstant(fieldType, field, fieldSetter, object, value, precision)
340337
|| assignString(fieldType, field, fieldSetter, object, value)
341338
|| assignDouble(fieldType, field, fieldSetter, object, value)
@@ -370,7 +367,7 @@ <T> boolean assignInstant(final Class<?> fieldType, final Field field, final Met
370367
} else {
371368
throw new InfluxDBMapperException("Unsupported type " + field.getClass() + " for field " + field.getName());
372369
}
373-
if(fieldSetter != null && fieldSetter.isAccessible()) {
370+
if(fieldSetter != null) {
374371
fieldSetter.invoke(object, instant);
375372
isInstantAssigned = true;
376373
} else {
@@ -385,7 +382,7 @@ <T> boolean assignString(final Class<?> fieldType, final Field field, final Meth
385382
boolean isStringAssigned = false;
386383
if(String.class.isAssignableFrom(fieldType)) {
387384
final String stringValue = String.valueOf(value);
388-
if(fieldSetter != null && fieldSetter.isAccessible()) {
385+
if(fieldSetter != null) {
389386
fieldSetter.invoke(object, stringValue);
390387
isStringAssigned = true;
391388
} else {
@@ -399,7 +396,7 @@ <T> boolean assignString(final Class<?> fieldType, final Field field, final Meth
399396
<T> boolean assignDouble(final Class<?> fieldType, final Field field, final Method fieldSetter, final T object, final Object value) throws InvocationTargetException, IllegalAccessException {
400397
boolean isDoubleAssigned = false;
401398
if(double.class.isAssignableFrom(fieldType) || Double.class.isAssignableFrom(fieldType)) {
402-
if(fieldSetter != null && fieldSetter.isAccessible()) {
399+
if(fieldSetter != null) {
403400
fieldSetter.invoke(object, value);
404401
isDoubleAssigned = true;
405402
} else if(double.class.isAssignableFrom(fieldType)) {
@@ -418,7 +415,7 @@ <T> boolean assignLong(final Class<?> fieldType, final Field field, final Method
418415
boolean isLongAssigned = false;
419416
if(long.class.isAssignableFrom(fieldType) || Long.class.isAssignableFrom(fieldType)) {
420417
final long longValue = ((Double) value).longValue();
421-
if(fieldSetter != null && fieldSetter.isAccessible()) {
418+
if(fieldSetter != null) {
422419
fieldSetter.invoke(object, longValue);
423420
isLongAssigned = true;
424421
} else if(long.class.isAssignableFrom(fieldType)) {
@@ -436,7 +433,7 @@ <T> boolean assignInteger(final Class<?> fieldType, final Field field, final Met
436433
boolean isIntegerAssigned = false;
437434
if(int.class.isAssignableFrom(fieldType) || Integer.class.isAssignableFrom(fieldType)) {
438435
final int intValue = ((Double) value).intValue();
439-
if(fieldSetter != null && fieldSetter.isAccessible()) {
436+
if(fieldSetter != null) {
440437
fieldSetter.invoke(object, intValue);
441438
isIntegerAssigned = true;
442439
} else if(int.class.isAssignableFrom(fieldType)) {
@@ -454,7 +451,7 @@ <T> boolean assignBoolean(final Class<?> fieldType, final Field field, final Met
454451
boolean isBooleanAssigned = false;
455452
if(boolean.class.isAssignableFrom(fieldType) || Boolean.class.isAssignableFrom(fieldType)) {
456453
final boolean boolValue = Boolean.parseBoolean(String.valueOf(value));
457-
if(fieldSetter != null && fieldSetter.isAccessible()) {
454+
if(fieldSetter != null) {
458455
fieldSetter.invoke(object, boolValue);
459456
isBooleanAssigned = true;
460457
} else if(boolean.class.isAssignableFrom(fieldType)) {

0 commit comments

Comments
 (0)