Skip to content

Commit 61e6baf

Browse files
arilivigniCopilot
andcommitted
Step 3: drop redundant Playwright framing; keep unit tests + build
Step 3's graded checks are localStorage persistence, PR-links-issue, and build — it never runs Playwright. Verification here is the unit test plus the app build, which are enough to trust the diff before merge. Playwright is introduced fresh in Step 4 (preview + capture proof), so remove the duplicated headed-browser NOTE and headless TIP from Step 3, reframe the 'watch the agent test' step around unit tests + build (with a forward pointer to Step 4), and soften the confirm bullets so they don't imply a live browser click. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a9ddd07b-77bf-43e0-a5d9-c6426a067e0e
1 parent 65de811 commit 61e6baf

1 file changed

Lines changed: 5 additions & 16 deletions

File tree

.github/steps/3-step.md

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,10 @@ A few things to know about the build:
7979
> and it survives a reload.
8080
> - A pre-seeded, corrupted "mona-bookmarks" value doesn't break
8181
> Add — the app recovers instead of throwing.
82-
> - Manually type a URL in the browser UI, click the "Add bookmark"
83-
> button, and confirm the new row appears immediately without a
84-
> page reload.
85-
> - Confirm the rendered row visibly includes the exact " :: "
86-
> separator between the URL text and the slug.
82+
> - Adding a bookmark renders a new row immediately, without a
83+
> full page reload.
84+
> - The rendered row includes the exact " :: " separator between
85+
> the URL text and the slug.
8786
>
8887
> Then open a pull request — but don't merge it:
8988
> - Include "Closes https://github.com/{{full_repo_name}}/issues/2"
@@ -94,7 +93,7 @@ A few things to know about the build:
9493
> ```
9594
9695
<img width="360" alt="The build prompt in the session with the Build the bookmarks app issue #2 referenced as a chip" src="../images/step3-issue-prompt.png" />
97-
1. **Watch the agent test the implementation.** Building the feature includes verifying it — Copilot runs the app and the unit tests you asked for, adding a URL with and without `https://`, confirming bookmarks survive a reload, and checking that a corrupted `mona-bookmarks` value doesn't break **Add**. A browser window may pop up while it exercises the app; that's expected (see the notes below).
96+
1. **Watch the agent test the implementation.** Building the feature includes verifying it — Copilot runs the **unit tests** you asked for and builds the app, confirming a URL with and without `https://` is stored, that bookmarks survive a reload, and that a corrupted `mona-bookmarks` value doesn't break **Add**. You'll preview the app live and drive it with Playwright in **Step 4** — here the tests and build are enough to trust the diff before you merge.
9897
1. **Review the diff before you merge.** Agent merge opens the pull request that links issue **#2** for you — review the changes in the session's **Changes** tab (or a browser canvas on the PR). You'll merge it in **Activity 2** once you're satisfied.
9998
10099
<img width="440" alt="Session review of the base62 nextSlug helper (mona- prefixed slugs), persistence and event-wiring notes, with Changes +107 -21 and PR #4 buttons at the bottom" src="../images/ghcp-app-step3.png" />
@@ -119,16 +118,6 @@ A few things to know about the build:
119118
120119
<img width="360" alt="Session panel menu with the Build the bookmarks app issue selected to reopen it in the side panel" src="../images/step3-reopen-issue.png" />
121120
122-
> [!NOTE]
123-
> **A browser window may open on its own.** By default the Playwright MCP server launches a **headed** (visible) browser, so a separate window appears while Copilot tests your implementation — navigating to your app, adding the bookmark, and confirming it behaves as expected — then closes itself. That pop-up is expected; let it finish.
124-
125-
> [!TIP]
126-
> **Prefer no pop-up window?** Run Playwright **headless** so nothing appears on screen (it still runs the same tests). Add the `--headless` flag to the server args in `.github/mcp.json`, then start a new session so the change is picked up:
127-
>
128-
> ```json
129-
> "args": ["@playwright/mcp@latest", "--headless"]
130-
> ```
131-
132121
<details>
133122
<summary>Having trouble? 🤷</summary><br/>
134123

0 commit comments

Comments
 (0)