Do not add integrity attributes if the entire plugin is disabled

Author: sersorrel

plugin.jest.js

@@ -872,6 +872,7 @@ describe('CspHtmlWebpackPlugin', () => {
       webpackCompile(config, (csps, selectors) => {
         expect(csps['index.html']).toBeUndefined();
         expect(selectors['index.html']('meta').length).toEqual(1);
+        expect(selectors['index.html']('[integrity]').length).toEqual(0);
         done();
       });
     });
@@ -896,6 +897,7 @@ describe('CspHtmlWebpackPlugin', () => {
       webpackCompile(config, (csps, selectors) => {
         expect(csps['index.html']).toBeUndefined();
         expect(selectors['index.html']('meta').length).toEqual(1);
+        expect(selectors['index.html']('[integrity]').length).toEqual(0);
         done();
       });
     });
@@ -922,6 +924,7 @@ describe('CspHtmlWebpackPlugin', () => {
       webpackCompile(config, (csps, selectors) => {
         expect(csps['index.html']).toBeUndefined();
         expect(selectors['index.html']('meta').length).toEqual(1);
+        expect(selectors['index.html']('[integrity]').length).toEqual(0);
         done();
       });
     });
@@ -957,6 +960,8 @@ describe('CspHtmlWebpackPlugin', () => {
         expect(csps['index-disabled.html']).toBeUndefined();
         expect(selectors['index-enabled.html']('meta').length).toEqual(2);
         expect(selectors['index-disabled.html']('meta').length).toEqual(1);
+        expect(selectors['index-enabled.html']('[integrity]').length).toEqual(1);
+        expect(selectors['index-disabled.html']('[integrity]').length).toEqual(0);
         done();
       });
     });

plugin.js

@@ -431,6 +431,9 @@ class CspHtmlWebpackPlugin {
    * @param compileCb
    */
   addIntegrityAttributes(compilation, htmlPluginData, compileCb) {
+    if (!this.isEnabled(htmlPluginData)) {
+      return compileCb(null, htmlPluginData);
+    }
     if (this.hashEnabled['script-src'] !== false) {
       htmlPluginData.assetTags.scripts
         .filter((tag) => tag.attributes.src)