SlevomatCodingStandard.PHP.UselessParentheses: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Sniffs/PHP/UselessParenthesesSniff.php

@@ -60,6 +60,7 @@
 use const T_REQUIRE_ONCE;
 use const T_SELF;
 use const T_SEMICOLON;
+use const T_SL;
 use const T_SR;
 use const T_STATIC;
 use const T_STRING_CAST;
@@ -472,14 +473,17 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes
 			return;
 		}
 
+		$complicatedOperators = [T_INLINE_THEN, T_COALESCE, T_BITWISE_AND, T_BITWISE_OR, T_BITWISE_XOR, T_SL, T_SR];
+
 		$operatorsPointers = [];
 		$actualStartPointer = $parenthesisOpenerPointer + 1;
 		while (true) {
 			$pointer = TokenHelper::findNext(
 				$phpcsFile,
 				array_merge(
 					self::OPERATORS,
-					[T_OPEN_PARENTHESIS, T_INLINE_THEN, T_COALESCE, T_BITWISE_AND, T_BITWISE_OR, T_BITWISE_XOR],
+					[T_OPEN_PARENTHESIS],
+					$complicatedOperators,
 					Tokens::$comparisonTokens
 				),
 				$actualStartPointer,
@@ -490,7 +494,7 @@ private function checkParenthesesAroundOperators(File $phpcsFile, int $parenthes
 				break;
 			}
 
-			if (in_array($tokens[$pointer]['code'], [T_INLINE_THEN, T_COALESCE, T_BITWISE_AND, T_BITWISE_OR, T_BITWISE_XOR], true)) {
+			if (in_array($tokens[$pointer]['code'], $complicatedOperators, true)) {
 				return;
 			}
 

tests/Sniffs/PHP/data/uselessParenthesesNoErrors.php

@@ -172,6 +172,9 @@ function ($value) {
 
 $char = (0xF0 & ord('1')) >> 4;
 
+$char = ($ord - 0xc0 << 6) + ord($char[1]) - 0x80;
+$char = ($ord - 0xc0 >> 6) + ord($char[1]) - 0x80;
+
 $anotherObject = new ($object->getClassName());
 
 // Must be last