SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly: Some references were not detected

Author: kukulich

SlevomatCodingStandard/Helpers/ReferencedNameHelper.php

@@ -4,6 +4,7 @@
 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Util\Tokens;
+use function array_key_exists;
 use function array_merge;
 use function array_reverse;
 use function array_values;
@@ -326,7 +327,6 @@ private static function isReferencedName(File $phpcsFile, int $startPointer): bo
 
 		$skipTokenCodes = [
 			T_FUNCTION,
-			T_AS,
 			T_DOUBLE_COLON,
 			T_OBJECT_OPERATOR,
 			T_NULLSAFE_OBJECT_OPERATOR,
@@ -389,6 +389,11 @@ private static function isReferencedName(File $phpcsFile, int $startPointer): bo
 			return false;
 		}
 
+		if ($previousToken['code'] === T_AS && !array_key_exists('nested_parenthesis', $previousToken)) {
+			// "as" in "use" statement
+			return false;
+		}
+
 		$endPointer = self::getReferencedNameEndPointer($phpcsFile, $startPointer);
 		$referencedName = self::getReferenceName($phpcsFile, $startPointer, $endPointer);
 

tests/Helpers/ReferencedNameHelperTest.php

@@ -82,6 +82,11 @@ public function testGetAllReferencedNames(): void
 			['object', true, false],
 			['DateTime', false, false],
 			['DateTimeImmutable', false, false],
+			['\ForeachIterator1', false, false],
+			['\ForeachValue1', false, false],
+			['\ForeachIterator2', false, false],
+			['\ForeachKey', false, false],
+			['\ForeachValue2', false, false],
 		];
 
 		$names = ReferencedNameHelper::getAllReferencedNames($phpcsFile, 0);

tests/Helpers/data/lotsOfReferencedNames.php

@@ -221,3 +221,11 @@ public function generateRoute($router): string
 echo "something{$a(
 	[DateTimeImmutable::class, 'format']
 )}";
+
+foreach (\ForeachIterator1::$items as \ForeachValue1::$value) {
+
+}
+
+foreach (\ForeachIterator2::$items as \ForeachKey::$key => \ForeachValue2::$value) {
+
+}

tests/Sniffs/Namespaces/data/fixableReferenceViaFullyQualifiedName.fixed.php

@@ -11,6 +11,7 @@
 use const Boo\FOO;
 use function min;
 use const PHP_VERSION;
+use Foo\BarTwo;
 
 class Bar extends ObjectPrototype implements Iterator
 {
@@ -27,6 +28,12 @@ public function bar()
 		FOO;
 		min(1, 2);
 		PHP_VERSION;
+		foreach (BarTwo::$values as BarTwo::$value) {
+			echo BarTwo::$value;
+		}
+		foreach (BarTwo::$values as BarTwo::$key => BarTwo::$value) {
+			echo BarTwo::$key . BarTwo::$value;
+		}
 	}
 
 	public function foo(DoctrineColumn $doctrineColumn): \Nette\ObjectPrototype

tests/Sniffs/Namespaces/data/fixableReferenceViaFullyQualifiedName.php

@@ -19,6 +19,12 @@ public function bar()
 		\Boo\FOO;
 		min(1, 2);
 		PHP_VERSION;
+		foreach (\Foo\BarTwo::$values as \Foo\BarTwo::$value) {
+			echo \Foo\BarTwo::$value;
+		}
+		foreach (\Foo\BarTwo::$values as \Foo\BarTwo::$key => \Foo\BarTwo::$value) {
+			echo \Foo\BarTwo::$key . \Foo\BarTwo::$value;
+		}
 	}
 
 	public function foo(\Doctrine\ORM\Mapping\Column $doctrineColumn): \Nette\ObjectPrototype