Skip to content

Escape key doesn't work on wayland #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UtkarshVerma opened this issue Jul 3, 2022 · 7 comments · May be fixed by #716
Open

Escape key doesn't work on wayland #480

UtkarshVerma opened this issue Jul 3, 2022 · 7 comments · May be fixed by #716
Assignees

Comments

@UtkarshVerma
Copy link

Describe the bug
Pressing escape during a break doesn't exit safeeyes.

To Reproduce
Steps to reproduce the behavior:

  1. Take a break
  2. Press escape
  3. Nothing happens

Expected behavior
Safeeyes break should be stopped.

Desktop (please complete the following information):

  • OS: Arch Linux
  • Desktop Env: SwayWM / Wayland
  • Version: 2.1.3
@deltragon deltragon self-assigned this Jul 16, 2024
@archisman-panigrahi
Copy link
Collaborator

Given that we currently have a setting that does not allow breaks to be skipped, do we really want to add escape to skip a break? That would render #603 kind of useless

@deltragon
Copy link
Collaborator

@archisman-panigrahi This is referring to a feature that already exists on X11 - there, pressing Escape on the Break Screen does the same thing as clicking the "Skip" button. It also respects the setting from #603.
This issue is just complaining that Wayland is regressing here compared to X11.

@archisman-panigrahi
Copy link
Collaborator

I cannot reproduce with Arch Linux KDE 6.1.3 + Wayland + Safe Eyes 2.2.1.
The escape key closes the break screen.

If anyone can reproduce the issue, please reopen.

@deltragon
Copy link
Collaborator

Oh, that's surprising to me - I could have sworn I managed to reproduce this one.
I'll check tomorrow.

@deltragon
Copy link
Collaborator

I stumbled over this again testing 3.0.0b3, on Plasma 6 Wayland. Reopening.

@deltragon deltragon reopened this May 9, 2025
@archisman-panigrahi
Copy link
Collaborator

Is the intended feature something like this?

When skip button is shown, escape key plays the same role as the skip button.
When skip button is hidden, escape key does not do anything.

@deltragon
Copy link
Collaborator

Yes, this is the intended feature. This is also how it works on X11 (apart from some bugs).

@deltragon deltragon linked a pull request May 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants