JS: missing params deps array => fallback to [] to prevent infinite loop

Author: slorber

src/index.ts

@@ -231,6 +231,11 @@ const useAsyncInternal = <R = UnknownResult, Args extends any[] = UnknownArgs>(
   params: Args,
   options?: UseAsyncOptions<R>
 ): UseAsyncReturn<R, Args> => {
+  // Fallback missing params, only for JS users forgetting the deps array, to prevent infinite loops
+  // https://github.com/slorber/react-async-hook/issues/27
+  // @ts-ignore
+  !params && (params = []);
+
   const normalizedOptions = normalizeOptions<R>(options);
 
   const [currentParams, setCurrentParams] = useState<Args | null>(null);

test/useAsync.test.ts

@@ -93,6 +93,26 @@ describe('useAync', () => {
     expect(onError).not.toHaveBeenCalled();
   });
 
+  // See https://github.com/slorber/react-async-hook/issues/27
+  it('should handle async function without dependency array (shortcut) ', async () => {
+    const getFakeResultsAsync = () => Promise.resolve(fakeResults);
+
+    const { result, waitForNextUpdate } = renderHook(() =>
+      // It is better to always required a deps array for TS users, but JS users might forget it so...
+      // Should we allow this "shortcut" for TS users too? I'd rather not
+      // @ts-ignore
+      useAsync(getFakeResultsAsync)
+    );
+
+    expect(result.current.loading).toBe(true);
+
+    await waitForNextUpdate();
+
+    expect(result.current.result).toEqual(fakeResults);
+    expect(result.current.loading).toBe(false);
+    expect(result.current.error).toBeUndefined();
+  });
+
   it('should resolve a successful real-world requests with potential race conditions', async () => {
     const onSuccess = jest.fn();
     const onError = jest.fn();