Fixes zammad#5541 - The use of X-On-Behalf-Of in a REST call leads to a 500 error message.

Co-authored-by: Mantas Masalskis <[email protected]>

Author: rolfschmidt

app/controllers/application_controller/has_user.rb

@@ -24,7 +24,8 @@ def current_user_real
   def request_header_from
     @request_header_from ||= begin
       if request.headers['X-On-Behalf-Of'].present?
-        ActiveSupport::Deprecation.send(:warn, "Header 'X-On-Behalf-Of' is deprecated. Please use header 'From' instead.") # rubocop:disable Zammad/DetectTranslatableString
+        ActiveSupport::Deprecation.new.warn("Header 'X-On-Behalf-Of' is deprecated. Please use header 'From' instead.")
+        Rails.logger.warn("Header 'X-On-Behalf-Of' is deprecated. Please use header 'From' instead.")
       end
 
       request.headers['From'] || request.headers['X-On-Behalf-Of']

lib/background_services/service_config.rb

@@ -9,7 +9,8 @@ def self.configuration_from_env(input)
       if !input['ZAMMAD_PROCESS_SESSIONS_JOBS_WORKERS'] && input['ZAMMAD_SESSION_JOBS_CONCURRENT']
         input['ZAMMAD_PROCESS_SESSIONS_JOBS_WORKERS'] = input['ZAMMAD_SESSION_JOBS_CONCURRENT']
 
-        ActiveSupport::Deprecation.send(:warn, 'The environment variable ZAMMAD_SESSION_JOBS_CONCURRENT is deprecated, please use ZAMMAD_PROCESS_SESSIONS_JOBS_WORKERS instead.') # rubocop:disable Zammad/DetectTranslatableString
+        ActiveSupport::Deprecation.new.warn('The environment variable ZAMMAD_SESSION_JOBS_CONCURRENT is deprecated, please use ZAMMAD_PROCESS_SESSIONS_JOBS_WORKERS instead.')
+        Rails.logger.warn('The environment variable ZAMMAD_SESSION_JOBS_CONCURRENT is deprecated, please use ZAMMAD_PROCESS_SESSIONS_JOBS_WORKERS instead.')
       end
 
       BackgroundServices

spec/lib/background_services/service_config_spec.rb

@@ -59,14 +59,16 @@
     end
 
     it 'handles the deprecated setting ZAMMAD_SESSION_JOBS_CONCURRENT correctly', :aggregate_failures do
-      allow(ActiveSupport::Deprecation).to receive(:warn)
+      deprecator = instance_double(ActiveSupport::Deprecation)
+      allow(ActiveSupport::Deprecation).to receive(:new).and_return(deprecator)
+      allow(deprecator).to receive(:warn)
       hash = { 'ZAMMAD_SESSION_JOBS_CONCURRENT' => 2 }
 
       configurations = described_class.configuration_from_env(hash)
       single_config = configurations.find { |config| config.service == BackgroundServices::Service::ProcessSessionsJobs }
 
       expect(single_config.workers).to be(2)
-      expect(ActiveSupport::Deprecation).to have_received(:warn).once
+      expect(deprecator).to have_received(:warn).once
     end
   end