fix: imgur is not fecthing, probably missing client-id

slurdge · Jan 5, 2024 · c7c1380 · c7c1380
1 parent aed0a75
commit c7c1380
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -48,7 +48,7 @@ jobs:
         python3 gox.py 
         -osarch="linux/386 linux/amd64 linux/arm linux/arm64 darwin/amd64 darwin/arm64 windows/amd64 windows/386" 
         -output "build/{{.Dir}}_{{.OS}}_{{.Arch}}" 
-        -ldflags "-w -s -X github.com/slurdge/goeland/version.GitCommit=${{ env.GIT_COMMIT }} -X github.com/slurdge/goeland/version.BuildDate=${{ env.BUILD_DATE }} -X github.com/slurdge/goeland/internal/goeland/fetch.clientID=${IMGUR_CLIENT_ID}"
+        -ldflags "-w -s -X github.com/slurdge/goeland/version.GitCommit=${{ env.GIT_COMMIT }} -X github.com/slurdge/goeland/version.BuildDate=${{ env.BUILD_DATE }} -X github.com/slurdge/goeland/internal/goeland/fetch.clientID=${{ secrets.IMGUR_CLIENT_ID }}"
 
 # Commented out because
 # MacOS seems unsupported

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -57,7 +57,7 @@ jobs:
         build-args: |
           BUILD_DATE=${{ steps.var.outputs.BUILD_DATE }}
           GIT_COMMIT=${{ steps.var.outputs.GIT_COMMIT }}
-          IMGUR_CLIENT_ID=$${ secrets.IMGUR_CLIENT_ID }}
+          IMGUR_CLIENT_ID=${{ secrets.IMGUR_CLIENT_ID }}
         platforms: linux/amd64,linux/arm64,linux/arm/v6,linux/arm/v7
         push: ${{ startsWith(github.ref, 'refs/tags/') }}
         tags: |

diff --git a/internal/goeland/fetch/imgur.go b/internal/goeland/fetch/imgur.go
@@ -3,7 +3,7 @@ package fetch
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"time"
 
@@ -38,7 +38,7 @@ type imgurRoot struct {
 var clientID = ""
 
 func fetchImgurTag(source *goeland.Source, tag string, sort string) error {
-	url := "https://api.imgur.com/3/gallery/t/" + tag + "/" + sort + "/0/day"
+	url := "https://api.imgur.com/3/gallery/t/" + tag + "/" + sort + "/day/0"
 	client := http.Client{Timeout: time.Second * 3}
 
 	req, err := http.NewRequest(http.MethodGet, url, nil)
@@ -58,7 +58,7 @@ func fetchImgurTag(source *goeland.Source, tag string, sort string) error {
 		return err
 	}
 
-	data, err := ioutil.ReadAll(res.Body)
+	data, err := io.ReadAll(res.Body)
 	if err != nil {
 		return err
 	}