Skip to content

Commit 112f8f5

Browse files
committed
autocomplete: Sort user-mention autocomplete results
Fixes: zulip#228
1 parent 43561bf commit 112f8f5

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

lib/model/autocomplete.dart

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import 'package:collection/collection.dart';
12
import 'package:flutter/foundation.dart';
23
import 'package:flutter/services.dart';
34

@@ -266,11 +267,12 @@ class MentionAutocompleteView extends ChangeNotifier {
266267

267268
final User user = iterator.current;
268269
if (query.testUser(user, store.autocompleteViewManager.autocompleteDataCache)) {
269-
results.add(UserMentionAutocompleteResult(userId: user.userId));
270+
results.add(UserMentionAutocompleteResult(userId: user.userId, fullName: user.fullName));
270271
}
271272
}
272273
}
273-
return results; // TODO(#228) sort for most relevant first
274+
return results.sortedBy((result) =>
275+
(result as UserMentionAutocompleteResult).fullName.toLowerCase()); // TODO(#228) sort for most relevant first
274276
}
275277
}
276278

@@ -344,9 +346,10 @@ class AutocompleteDataCache {
344346
sealed class MentionAutocompleteResult {}
345347

346348
class UserMentionAutocompleteResult extends MentionAutocompleteResult {
347-
UserMentionAutocompleteResult({required this.userId});
349+
UserMentionAutocompleteResult({required this.userId, required this.fullName});
348350

349351
final int userId;
352+
final String fullName;
350353
}
351354

352355
// TODO(#233): // class UserGroupMentionAutocompleteResult extends MentionAutocompleteResult {

0 commit comments

Comments
 (0)