Merge pull request #186 from ajitid/master

smacke · web-flow · commit 1f098e77d93e · 2024-03-17T22:16:44.000-07:00
fix: don't report sync as successful if best score is in negatives
diff --git a/ffsubsync/ffsubsync.py b/ffsubsync/ffsubsync.py
@@ -178,6 +178,8 @@ def try_sync(
                     reference_pipe.transform(args.reference),
                     srt_pipes,
                 )
+            if best_score < 0:
+                sync_was_successful = False
             logger.info("...done")
             offset_seconds = (
                 offset_samples / float(SAMPLE_RATE) + args.apply_offset_seconds

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,8 @@ def try_sync(`
`178`	`178`	`reference_pipe.transform(args.reference),`
`179`	`179`	`srt_pipes,`
`180`	`180`	`)`
	`181`	`+ if best_score < 0:`
	`182`	`+ sync_was_successful = False`
`181`	`183`	`logger.info("...done")`
`182`	`184`	`offset_seconds = (`
`183`	`185`	`offset_samples / float(SAMPLE_RATE) + args.apply_offset_seconds`