Lesson 7: TypeError: Cannot read properties of undefined (reading 'getBalance')

[TLBTrung-222]

I'm using ethers 6.7.0, while I'm testing the withdraw test, it's failed with the error
TypeError: Cannot read properties of undefined (reading 'getBalance')
others test can run properly without error.

Here is my withdraw test

describe("withdraw", function () {
        // the contract need to have some ether before withdrawing
        beforeEach(async function () {
            await fundMe.fund({ value: sendValue });
        });

        it("withdraw Ether from contract to owner", async function () {
            //* Arrange
            // First, we need to retrieve the balance of the owner (deployer) and the contract
            const startingFundMeBalance = await fundMe.provider.getBalance(
                fundMe.address
            );
            const startingDeployerBalance = await fundMe.provider.getBalance(
                deployer
            );

            //* Act
            // Let's perform the withdraw and retrieve the result
            const transactionResponse = await fundMe.withdraw();
            const transactionReceipt = await transactionResponse.wait(1);

            const endingFundMeBalance = await fundMe.provider.getBalance(
                fundMe.address
            );
            const endingDeployerBalance = await fundMe.provider.getBalance(
                deployer
            );

            //* Assert
            // Need to compare if the contract's balance down to 0, and the owner's balance added contract's fund

            assert.equal(endingFundMeBalance, 0);
            assert.equal(
                endingDeployerBalance,
                startingDeployerBalance + startingFundMeBalance
            );
        });
    });

This is my repo for further review.
Please help me to correct it, thank you very much

[TLBTrung-222]

It's look like in ether v6, I can not use fundMe.provider, so I have changed the fundMe to ethers to access the getBalance method. But now it's throw me an error:
TypeError: unsupported addressable value (argument="target", value=null, code=INVALID_ARGUMENT, version=6.7.0)
here is my updated code

describe("withdraw", function () {
        // the contract need to have some ether before withdrawing
        beforeEach(async function () {
            await fundMe.fund({ value: sendValue });
        });

        it("withdraw Ether from contract to owner", async function () {
            //* Arrange
            // First, we need to retrieve the balance of the owner (deployer) and the contract
            const startingFundMeBalance = await ethers.provider.getBalance(
                fundMe.address
            );
            const startingDeployerBalance = await ethers.provider.getBalance(
                deployer
            );

            //* Act
            // Let's perform the withdraw and retrieve the result
            const transactionResponse = await fundMe.withdraw();
            const transactionReceipt = await transactionResponse.wait(1);

            const endingFundMeBalance = await ethers.provider.getBalance(
                fundMe.address
            );
            const endingDeployerBalance = await ethers.provider.getBalance(
                deployer
            );

            //* Assert
            // Need to compare if the contract's balance down to 0, and the owner's balance added contract's fund

            assert.equal(endingFundMeBalance, 0);
            assert.equal(
                endingDeployerBalance,
                startingDeployerBalance + startingFundMeBalance
            );
        });
    });

Please help me to figure out what cause the error. Thank you for giving attention

[Nlferu]

Hello @TLBTrung-222

First solution: downgrade your ethers to 5.x.x

Second Solution: Ethers version 6 uses getAddress() function to retrieve the contract address, while the previous version 5 uses .address property. If you are still using ethers 6 (seems like you do) then replace .address with .getAddress() and it should fix your issue.

[TLBTrung-222]

thank you so much, I change to .getAddress() and it's fixed the issue.

[Nlferu]

Glad I could help ;)

[TLBTrung-222]

Hi @Neftyr , I have reviewed my code and realized that in the constructor test, I just use .address property for mockV3Aggregator contract and it still works. This is the result when I run:

It's weird because when I use .getAddress for it, it returns undefined as shown below

Both fundMe and mockV3Aggregator are created by ethers.getContract method. I can not find a reason for this error, can you help me with that? This is my test file for further review. Thank you very much.

[Nlferu]

Hi @TLBTrung-222

To be honest I'm not sure (it should work like that if you are using ethers 6) but I think there is issue with your package.json file and your installed packages have been somehow corrupted. In order to get smooth through this course I would recommend you to do following:

1. Delete node_modules file.
2. Copy code from course repository from package.json then clear your package.json and paste there copied code.
3. Then run yarn command to install all packages required for this course.
4. Use packages versions from course instead of updated/ new ones.
5. You will be able to use updated ones once you get some more experience.

If you want still fight with ethers v6 visit this: link

[v4ss]

Hi @TLBTrung-222,

In ethers v6, you have to replace fundMe.address by fundMe.target to get the contract address. You can also use the @Nlferu solution : await fundMe.getAddress().

Then, to use getBalance() function, you have to replace fundMe.provider.getBalance(fundMe.target) by ethers.provider.getBalance(fundMe.target)

Another issue is the effectiveGasPrice variable. In the new version of ether, this variable change for gasPrice.

And finally, the .mul() function used in the tuto to get the gasCost isn't works in v6. You can just use the operators *, +. Don't forget to also use these operators in the assert and to remove the .toString()

My code that works :

const { deployments, ethers, getNamedAccounts } = require("hardhat");
const { assert, expect } = require("chai");

describe("FundMe", async function () {
    let fundMe;
    let deployer;
    let mockV3Aggregator;
    const sendValue = ethers.parseEther("1"); // 1 ETH
    beforeEach(async function () {
        // deploy our fundMe contract
        // using Hardhat deploy
        // const accounts = await ethers.getSigners();
        // const accountZero = accounts[0];
        deployer = (await getNamedAccounts()).deployer;
        await deployments.fixture(["all"]); // Deploy all the contract tags with "all"

        // Get contracts
        fundMe = await ethers.getContract("FundMe", deployer);
        mockV3Aggregator = await ethers.getContract(
            "MockV3Aggregator",
            deployer,
        );
    });

    describe("constructor", async function () {
        it("Sets the aggregator addresses correctly", async function () {
            const response = await fundMe.priceFeed();
            assert.equal(response, mockV3Aggregator.target);
        });
    });

    describe("fund", async function () {
        it("Fails if you don't send enough ETH", async function () {
            await expect(fundMe.fund()).to.be.revertedWith(
                "Didn't send enough!",
            );
        });
        it("Updated the amount funded data structure", async function () {
            await fundMe.fund({ value: sendValue });
            const response = await fundMe.addressToAmountFunded(deployer);
            assert.equal(response.toString(), sendValue.toString());
        });
        it("Add funder to array of funders", async function () {
            await fundMe.fund({ value: sendValue });
            const response = await fundMe.funders(0);
            assert.equal(response, deployer);
        });
    });

    describe("withdraw", async function () {
        beforeEach(async function () {
            await fundMe.fund({ value: sendValue });
        });

        it("Withdraw ETH from a single founder", async function () {
            // Arrange
            const startingFundMeBalance = await ethers.provider.getBalance(
                fundMe.target,
            );
            const startingDeployerBalance =
                await ethers.provider.getBalance(deployer);

            // Act
            const transactionResponse = await fundMe.withdraw();
            const transactionReceipt = await transactionResponse.wait(1);
            // Get the Gas price used
            const { gasUsed, gasPrice } = transactionReceipt;
            const gasCost = gasUsed * gasPrice;

            const endingFundMeBalance = await ethers.provider.getBalance(
                fundMe.target,
            );
            const endingDeployerBalance =
                await ethers.provider.getBalance(deployer);

            // Assert
            assert.equal(endingFundMeBalance, 0);
            assert.equal(
                startingFundMeBalance + startingDeployerBalance,
                endingDeployerBalance + gasCost,
            );
        });
    });
});

[tai9856]

You're the best, I hate using previous version just to get it done, when I already started to get used to the new version. And it also came with much more problems to solve about comparable version with other packages. Many thanks.

[shureedshazzad]

Thanks,v4ss. I’ve been struggling with this test code for two days. I really appreciate your help.

[dominicjin]

Great! Really helpful.