You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Migrate app from dapple to dapp and fix simple warnings.
Couldn't run unit tests under dapple due to boost error. Since dapple is
deprecated anyway, makes sense to migrate to dapp.
Warnings fixed are:
- Use of 'var' deprecated
- Local variable 'len' shadows contract function 'len'
The warnings that remain are:
- use of labels deprecated warning (findPtr, rFindPtr)
- Jump instructions can lead to incorrect stack access (findPtr, rFindPtr)
- Function state mutability can be restricted to pure (various)
Last warning could be fixed easily, but it is easier to apply to all functions
at once once findPtr, rFindPtr can be declared pure.
Some functions (toSlice, compare) have been overloaded to accept either strings
or slices, calling on strings will cause "<name> not visible after argument
dependent lookup in literal_string" errors using compiler version 0.4.21.
Remainder of functions to be updated in a later commit
--
testCompare is failing with a BadInstruction error, possibly OOB error
when using mload.
0 commit comments