Initial semi-working version

Author: smith

init.rb

@@ -1,3 +1,2 @@
 require 'firephp'
 
-ActionController::Base.extend(FirePHP)

lib/firephp.rb

@@ -1,7 +1,40 @@
 module FirePHP
-  private
+  def self.included(controller)
+    controller.after_filter :firephp_filter
+  end
 
+  protected
     def firephp(obj = "", type = :log)
+      @firephp ||= {}
+      types = [:log, :info, :warn, :error] 
+      type = (types.include?(type) ? type : :log).to_s.upcase
+      @firephp[type] ||= []
+      @firephp[type] << obj
     end
     alias_method :fb, :firephp
+
+  private
+    def firephp_filter
+      # Add headers only when browser has FirePHP-Plugin
+      return if !(request.headers["HTTP_USER_AGENT"]=~/FirePHP\//)
+      # Do not add headers in production mode
+      return if ENV["RAILS_ENV"] == "production"
+      return if @firephp.blank?
+      
+      headers["X-FirePHP-Data-100000000001"]='{'
+      headers["X-FirePHP-Data-200000000001"]='"FirePHP.Dump":{'
+      headers["X-FirePHP-Data-200000000002"]="\"RailsVersion\":\"#{RAILS_GEM_VERSION}\","
+      headers["X-FirePHP-Data-299999999999"]='"__SKIP__":"__SKIP__"},'
+      headers["X-FirePHP-Data-300000000001"]='"FirePHP.Firebug.Console":['
+      count=2
+      @firephp.each do |type, arr|
+        next if !(type=~/^(LOG|INFO|WARN|ERROR)$/)
+        arr.each do |a|
+          headers["X-FirePHP-Data-3#{sprintf("%011d", count)}"]="[\"#{type}\",#{a.to_json}],"
+          count+=1
+        end
+      end
+      headers["X-FirePHP-Data-399999999999"]='["__SKIP__"]],'
+      headers["X-FirePHP-Data-999999999999"]='"__SKIP__":"__SKIP__"}'
+    end
 end

test/firephp_rails_test.rb

@@ -1,11 +1,47 @@
 require 'test_helper'
 
-class FirephpRailsTest < ActiveSupport::TestCase
+class FirePHPController < ActionController::Base
+  include FirePHP
+
+  def a
+    firephp("hi")
+    render :nothing => true
+  end
+
+
+  def b
+    fb("hi")
+    render :nothing => true
+  end
+end
+
+class FirePHPControllerTest < ActionController::TestCase
+  EXAMPLE_HEADER = "X-FirePHP-Data-100000000001"
+
   test "firephp method exists" do
-    assert ActionController::Base.private_methods.include?("firephp")
+    get :a
   end
 
   test "fb method exists" do
-    assert ActionController::Base.private_methods.include?("fb")
+    get :b
   end
+
+  test "headers not sent on non-firephp enabled request" do
+    get :a
+    assert !@response.headers.include?(EXAMPLE_HEADER)
+  end
+
+  test "headers sent on firephp enabled request" do
+    @request.env["HTTP_USER_AGENT"] = "FirePHP/"
+    get :a
+    assert @response.headers.include?(EXAMPLE_HEADER)
+  end
+
+  test "headers not sent in production mode" do
+    ENV["RAILS_ENV"] = "production"
+    get :a
+    assert !@response.headers.include?(EXAMPLE_HEADER)
+    ENV["RAILS_ENV"] = "test"
+  end
+
 end