Skip to content

Commit fdea2d7

Browse files
authored
fix(codegen): use undefined placeholder for unhandled trait (#1629)
1 parent efcdd17 commit fdea2d7

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitGenerator.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import software.amazon.smithy.model.traits.EventHeaderTrait;
1515
import software.amazon.smithy.model.traits.EventPayloadTrait;
1616
import software.amazon.smithy.model.traits.HostLabelTrait;
17+
import software.amazon.smithy.model.traits.HttpChecksumRequiredTrait;
1718
import software.amazon.smithy.model.traits.HttpErrorTrait;
1819
import software.amazon.smithy.model.traits.HttpHeaderTrait;
1920
import software.amazon.smithy.model.traits.HttpLabelTrait;
@@ -60,6 +61,7 @@ public class SchemaTraitGenerator {
6061
HttpPayloadTrait.ID,
6162
HttpQueryParamsTrait.ID,
6263
HttpResponseCodeTrait.ID,
64+
HttpChecksumRequiredTrait.ID,
6365
HostLabelTrait.ID,
6466
SparseTrait.ID,
6567
SensitiveTrait.ID,
@@ -124,7 +126,17 @@ public String serializeTraitData(Trait trait, StringStore stringStore) {
124126
} else if (SchemaTraitExtension.INSTANCE.contains(trait)) {
125127
return SchemaTraitExtension.INSTANCE.render(trait);
126128
}
129+
130+
if (trait instanceof StringTrait stringTrait) {
131+
return """
132+
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */ "
133+
+ stringStore.var(stringTrait.getValue());
134+
} else if (trait instanceof AnnotationTrait) {
135+
return """
136+
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */ "
137+
+ ANNOTATION_TRAIT_VALUE;
138+
}
127139
return """
128-
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */";
140+
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */ void 0";
129141
}
130142
}

0 commit comments

Comments
 (0)