fix: fix tests

Author: wa0x6e

src/writer/proposal.ts

@@ -17,7 +17,7 @@ export async function getSpaceProposalsLimits(
   space: { verified: boolean; turbo: boolean; flagged: boolean; id: string },
   interval: 'day' | 'month'
 ): Promise<number> {
-  return getLimit(`space.${getSpaceType(space, true)}.proposal_limit_per_${interval}`);
+  return getLimit(`space.${await getSpaceType(space, true)}.proposal_limit_per_${interval}`);
 }
 
 export const getProposalsCount = async (space, author) => {
@@ -209,12 +209,12 @@ export async function verify(body): Promise<any> {
     return Promise.reject('failed to check proposals limit');
   }
 
-  const bodyLengthLimit = await getLimit(`space.${getSpaceType(space)}.body_limit`);
+  const bodyLengthLimit = await getLimit(`space.${await getSpaceType(space)}.body_limit`);
   if (msg.payload.body.length > bodyLengthLimit) {
     return Promise.reject(`proposal body length can not exceed ${bodyLengthLimit} characters`);
   }
 
-  const choicesLimit = await getLimit(`space.${getSpaceType(space)}.choices_limit`);
+  const choicesLimit = await getLimit(`space.${await getSpaceType(space)}.choices_limit`);
   if (msg.payload.choices.length > choicesLimit) {
     return Promise.reject(`number of choices can not exceed ${choicesLimit}`);
   }

src/writer/settings.ts

@@ -4,7 +4,7 @@ import isEqual from 'lodash/isEqual';
 import { addOrUpdateSpace, getSpace } from '../helpers/actions';
 import log from '../helpers/log';
 import db from '../helpers/mysql';
-import { getLimit } from '../helpers/options';
+import { getLimit, getSpaceType } from '../helpers/options';
 import { clearStampCache, DEFAULT_NETWORK, jsonParse } from '../helpers/utils';
 
 const SNAPSHOT_ENV = process.env.NETWORK || 'testnet';
@@ -74,9 +74,7 @@ export async function verify(body): Promise<any> {
     return Promise.reject(e);
   }
 
-  const strategiesLimit = await getLimit(
-    `space.${space.turbo ? 'turbo' : 'default'}.strategies_limit`
-  );
+  const strategiesLimit = await getLimit(`space.${await getSpaceType(space)}.strategies_limit`);
 
   if (msg.payload.strategies.length > strategiesLimit) {
     return Promise.reject(`max number of strategies is ${strategiesLimit}`);

test/unit/writer/proposal.test.ts

@@ -9,14 +9,29 @@ const LIMITS = {
   'space.active_proposal_limit_per_author': 20,
   'space.ecosystem.proposal_limit_per_day': 150,
   'space.ecosystem.proposal_limit_per_month': 750,
+  'space.ecosystem.choices_limit': 20,
+  'space.ecosystem.body_length': 10000,
+  'space.ecosystem.strategies_limit': 8,
   'space.flagged.proposal_limit_per_day': 5,
   'space.flagged.proposal_limit_per_month': 7,
+  'space.flagged.choices_limit': 20,
+  'space.flagged.body_length': 10000,
+  'space.flagged.strategies_limit': 8,
   'space.default.proposal_limit_per_day': 10,
   'space.default.proposal_limit_per_month': 150,
+  'space.default.choices_limit': 20,
+  'space.default.body_length': 10000,
+  'space.default.strategies_limit': 8,
   'space.turbo.proposal_limit_per_day': 40,
   'space.turbo.proposal_limit_per_month': 200,
+  'space.turbo.choices_limit': 1000,
+  'space.turbo.body_length': 40000,
+  'space.turbo.strategies_limit': 8,
   'space.verified.proposal_limit_per_day': 20,
   'space.verified.proposal_limit_per_month': 100,
+  'space.verified.choices_limit': 20,
+  'space.verified.body_length': 10000,
+  'space.verified.strategies_limit': 6,
   'user.default.follow.limit': 25
 };
 const ECOSYSTEM_LIST = ['test.eth', 'snapshot.eth'];

test/unit/writer/settings.test.ts

@@ -18,6 +18,52 @@ function randomStrategies(count = 1) {
     }));
 }
 
+const LIMITS = {
+  'space.active_proposal_limit_per_author': 20,
+  'space.ecosystem.proposal_limit_per_day': 150,
+  'space.ecosystem.proposal_limit_per_month': 750,
+  'space.ecosystem.choices_limit': 20,
+  'space.ecosystem.body_length': 10000,
+  'space.ecosystem.strategies_limit': 8,
+  'space.flagged.proposal_limit_per_day': 5,
+  'space.flagged.proposal_limit_per_month': 7,
+  'space.flagged.choices_limit': 20,
+  'space.flagged.body_length': 10000,
+  'space.flagged.strategies_limit': 8,
+  'space.default.proposal_limit_per_day': 10,
+  'space.default.proposal_limit_per_month': 150,
+  'space.default.choices_limit': 20,
+  'space.default.body_length': 10000,
+  'space.default.strategies_limit': 8,
+  'space.turbo.proposal_limit_per_day': 40,
+  'space.turbo.proposal_limit_per_month': 200,
+  'space.turbo.choices_limit': 1000,
+  'space.turbo.body_length': 40000,
+  'space.turbo.strategies_limit': 10,
+  'space.verified.proposal_limit_per_day': 20,
+  'space.verified.proposal_limit_per_month': 100,
+  'space.verified.choices_limit': 20,
+  'space.verified.body_length': 10000,
+  'space.verified.strategies_limit': 6,
+  'user.default.follow.limit': 25
+};
+const ECOSYSTEM_LIST = ['test.eth', 'snapshot.eth'];
+
+jest.mock('../../../src/helpers/options', () => {
+  const originalModule = jest.requireActual('../../../src/helpers/options');
+
+  return {
+    __esModule: true,
+    ...originalModule,
+    getList: () => {
+      return ECOSYSTEM_LIST;
+    },
+    getLimit: (key: string) => {
+      return LIMITS[key];
+    }
+  };
+});
+
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 const mockGetSpace = jest.fn((_): any => {
   return spacesGetSpaceFixtures;