fix: remove limits depending on space turbo status (#1115)

Co-authored-by: Chaitanya <[email protected]>
snapshot-labs · Feb 5, 2025 · 4b15afc · 4b15afc
1 parent d36e85f
commit 4b15afc
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 125 deletions.
diff --git a/src/schemas/proposal.json b/src/schemas/proposal.json
@@ -15,11 +15,7 @@
         "body": {
           "type": "string",
           "title": "body",
-          "minLength": 0,
-          "maxLengthWithSpaceType": {
-            "default": 10000,
-            "turbo": 40000
-          }
+          "minLength": 0
         },
         "discussion": {
           "type": "string",
@@ -30,11 +26,7 @@
         "choices": {
           "type": "array",
           "title": "choices",
-          "minItems": 1,
-          "maxLengthWithSpaceType": {
-            "default": 500,
-            "turbo": 1000
-          }
+          "minItems": 1
         },
         "labels": {
           "type": "array",

diff --git a/src/schemas/space.json b/src/schemas/space.json
@@ -120,10 +120,6 @@
         "strategies": {
           "type": "array",
           "minItems": 1,
-          "maxItemsWithSpaceType": {
-            "default": 8,
-            "turbo": 10
-          },
           "uniqueItems": true,
           "items": {
             "type": "object",

diff --git a/src/schemas/update-proposal.json b/src/schemas/update-proposal.json
@@ -19,11 +19,7 @@
         "body": {
           "type": "string",
           "title": "body",
-          "minLength": 0,
-          "maxLengthWithSpaceType": {
-            "default": 10000,
-            "turbo": 20000
-          }
+          "minLength": 0
         },
         "discussion": {
           "type": "string",
@@ -34,11 +30,7 @@
         "choices": {
           "type": "array",
           "title": "choices",
-          "minItems": 1,
-          "maxLengthWithSpaceType": {
-            "default": 500,
-            "turbo": 1000
-          }
+          "minItems": 1
         },
         "labels": {
           "type": "array",

diff --git a/src/utils.ts b/src/utils.ts
@@ -194,48 +194,6 @@ ajv.addKeyword({
   }
 });
 
-ajv.addKeyword({
-  keyword: 'maxLengthWithSpaceType',
-  validate: function validate(schema, data) {
-    // @ts-ignore
-    const spaceType = this.spaceType || 'default';
-    const isValid = data.length <= schema[spaceType];
-    if (!isValid) {
-      // @ts-ignore
-      validate.errors = [
-        {
-          keyword: 'maxLengthWithSpaceType',
-          message: `must not have more than ${schema[spaceType]}`,
-          params: { limit: schema[spaceType] }
-        }
-      ];
-    }
-    return isValid;
-  },
-  errors: true
-});
-
-ajv.addKeyword({
-  keyword: 'maxItemsWithSpaceType',
-  validate: function validate(schema, data) {
-    // @ts-ignore
-    const spaceType = this.spaceType || 'default';
-    const isValid = data.length <= schema[spaceType];
-    if (!isValid) {
-      // @ts-ignore
-      validate.errors = [
-        {
-          keyword: 'maxItemsWithSpaceType',
-          message: `must NOT have more than ${schema[spaceType]} items`,
-          params: { limit: schema[spaceType] }
-        }
-      ];
-    }
-    return isValid;
-  },
-  errors: true
-});
-
 // Custom URL format to allow empty string values
 // https://github.com/snapshot-labs/snapshot.js/pull/541/files
 ajv.addFormat('customUrl', {

diff --git a/test/examples/proposal-maxLengthWithSpaceType-error.json b/test/examples/proposal-maxLengthWithSpaceType-error.json
diff --git a/test/examples/space-maxItemsWithSpaceType-error.json b/test/examples/space-maxItemsWithSpaceType-error.json
diff --git a/test/schema.spec.ts b/test/schema.spec.ts
@@ -10,8 +10,6 @@ import profile from './examples/profile.json';
 import statement from './examples/statement.json';
 import alias from './examples/alias.json';
 import schemas from '../src/schemas';
-import proposalMaxLengthWithSpaceTypeError from './examples/proposal-maxLengthWithSpaceType-error.json';
-import spaceMaxItemsWithSpaceTypeError from './examples/space-maxItemsWithSpaceType-error.json';
 
 // Tests for default spaces
 describe.each([
@@ -49,29 +47,3 @@ describe.each([
     expect(isValid).toBe(true);
   });
 });
-
-// tests for default schema with turbo example, should fail
-describe.each([
-  {
-    schemaType: 'space',
-    schema: schemas.space,
-    example: spaceTurbo,
-    error: spaceMaxItemsWithSpaceTypeError
-  },
-  {
-    schemaType: 'proposal',
-    schema: schemas.proposal,
-    example: proposalTurbo,
-    error: proposalMaxLengthWithSpaceTypeError
-  }
-])(
-  `Run validate for default schema with turbo example`,
-  ({ schemaType, schema, example, error }) => {
-    test(`validating schema ${schemaType} should fail with error`, () => {
-      const isValid = validateSchema(schema, example, {
-        snapshotEnv: 'mainnet'
-      });
-      expect(isValid).toMatchObject(error);
-    });
-  }
-);