Skip to content

Commit 4fa590f

Browse files
ChaituVRChaituVR
authored
fix: remove extra hash in explorer URL (#1111)
1 parent cce805b commit 4fa590f

File tree

3 files changed

+42
-30
lines changed

3 files changed

+42
-30
lines changed

‎scripts/addNetwork.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const network = {
2727
multicall,
2828
rpc: [],
2929
explorer: {
30-
url: explorer
30+
url: explorer.replace(/\/$/, '')
3131
},
3232
start: parseInt(start, 10),
3333
logo: `ipfs://${logo}`

‎src/networks.json

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@
403403
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
404404
"rpc": [],
405405
"explorer": {
406-
"url": "https://explorer.evm.shimmer.network/"
406+
"url": "https://explorer.evm.shimmer.network"
407407
},
408408
"start": 1290,
409409
"logo": "ipfs://bafkreib4xhbgbhrwkmizp4d4nz3wzbpyhdm6wpz2v2pbkk7jxsgg3hdt74"
@@ -417,7 +417,7 @@
417417
"multicall": "0xA4029b74FBA366c926eDFA7Dd10B21C621170a4c",
418418
"rpc": [],
419419
"explorer": {
420-
"url": "https://puppyscan.shib.io/"
420+
"url": "https://puppyscan.shib.io"
421421
},
422422
"start": 3035769,
423423
"logo": "ipfs://bafkreig57igai5phg4icywc5yoockd52jo3hlvbkyi6wiufrmu4p2lmenm",
@@ -446,7 +446,7 @@
446446
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
447447
"rpc": [],
448448
"explorer": {
449-
"url": "http://opbnbscan.com/"
449+
"url": "http://opbnbscan.com"
450450
},
451451
"start": 512881,
452452
"logo": "ipfs://bafkreibll4la7wqerzs7zwxjne2j7ayynbg2wlenemssoahxxj5rbt6c64"
@@ -527,7 +527,7 @@
527527
"multicall": "0xF9cda624FBC7e059355ce98a31693d299FACd963",
528528
"rpc": [],
529529
"explorer": {
530-
"url": "https://sepolia.explorer.zksync.dev/"
530+
"url": "https://sepolia.explorer.zksync.dev"
531531
},
532532
"start": 2292,
533533
"logo": "ipfs://bafkreih6y7ri7h667cwxe5miisxghfheiidtbw2747y75stoxt3gp3a2yy",
@@ -577,7 +577,7 @@
577577
"https://mainnet.era.zksync.io"
578578
],
579579
"explorer": {
580-
"url": "https://explorer.zksync.io/"
580+
"url": "https://explorer.zksync.io"
581581
},
582582
"start": 3908235,
583583
"logo": "ipfs://bafkreih6y7ri7h667cwxe5miisxghfheiidtbw2747y75stoxt3gp3a2yy"
@@ -610,7 +610,7 @@
610610
"https://rpc.pulsechain.com"
611611
],
612612
"explorer": {
613-
"url": "https://scan.pulsechain.com/"
613+
"url": "https://scan.pulsechain.com"
614614
},
615615
"start": 17657774,
616616
"logo": "ipfs://QmWUsiEWdejtHZ9B9981TYXn7Ds8C7fkB1S4h5rP3kCCZR"
@@ -739,7 +739,7 @@
739739
"https://archive.evm.testnet.shimmer.network/v1/chains/rms1pr75wa5xuepg2hew44vnr28wz5h6n6x99zptk2g68sp2wuu2karywgrztx3/evm"
740740
],
741741
"explorer": {
742-
"url": "https://explorer.evm.testnet.shimmer.network/"
742+
"url": "https://explorer.evm.testnet.shimmer.network"
743743
},
744744
"start": 10614,
745745
"logo": "ipfs://bafkreihtwfwrue7klzedwx4rqlk6agklz4lbbk7owsyw6xzn6c2m4t5tgy"
@@ -801,7 +801,7 @@
801801
"https://rpc.api.moonbeam.network"
802802
],
803803
"explorer": {
804-
"url": "https://moonscan.io/"
804+
"url": "https://moonscan.io"
805805
},
806806
"start": 171135,
807807
"logo": "ipfs://QmWKTEK2pj5sBBbHnMHQbWgw6euVdBrk2Ligpi2chrWASk"
@@ -863,7 +863,7 @@
863863
"multicall": "0xe033Bed7cae4114Af84Be1e9F1CA7DEa07Dfe1Cf",
864864
"rpc": [],
865865
"explorer": {
866-
"url": "https://seitrace.com/"
866+
"url": "https://seitrace.com"
867867
},
868868
"start": 79164574,
869869
"logo": "ipfs://bafkreiammyt7uztbztqbcqv4bydnczsh2fqmnjf6jxj4xnskzzl6sjrigq"
@@ -877,7 +877,7 @@
877877
"multicall": "0xD8d2dFca27E8797fd779F8547166A2d3B29d360E",
878878
"rpc": [],
879879
"explorer": {
880-
"url": "https://islander.vanascan.io/"
880+
"url": "https://islander.vanascan.io"
881881
},
882882
"start": 716763,
883883
"logo": "ipfs://bafkreibotel3dmc5og5rf3tpt7l74awkene7x6q3oxtwhptt4y4rpa7vsa"
@@ -999,7 +999,7 @@
999999
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
10001000
"rpc": [],
10011001
"explorer": {
1002-
"url": "https://kavascan.com/"
1002+
"url": "https://kavascan.com"
10031003
},
10041004
"start": 3661165,
10051005
"logo": "ipfs://bafkreibpfubharx32fjqkqbfdhygwdjb2khxdg6meaasrcxsgvowos26f4"
@@ -1029,7 +1029,7 @@
10291029
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
10301030
"rpc": [],
10311031
"explorer": {
1032-
"url": "https://holesky.fraxscan.com/"
1032+
"url": "https://holesky.fraxscan.com"
10331033
},
10341034
"start": 1,
10351035
"logo": "ipfs://bafkreieflj4wq6tx7k5kq47z3xnsrdrn2xgm4bxa3uovrnndcb2vqqwlyu",
@@ -1044,7 +1044,7 @@
10441044
"multicall": "0xc454132B017b55b427f45078E335549A7124f5f7",
10451045
"rpc": [],
10461046
"explorer": {
1047-
"url": "https://peaq.subscan.io/"
1047+
"url": "https://peaq.subscan.io"
10481048
},
10491049
"start": 3525964,
10501050
"logo": "ipfs://bafkreidqkleori7pmilesz4t52iebebaqf3oflzmoz646qfuaznanb3sgm"
@@ -1072,7 +1072,7 @@
10721072
"multicall": "0x4956F15eFdc3dC16645e90Cc356eAFA65fFC65Ec",
10731073
"rpc": [],
10741074
"explorer": {
1075-
"url": "https://subnets.avax.network/beam/"
1075+
"url": "https://subnets.avax.network/beam"
10761076
},
10771077
"start": 1,
10781078
"logo": "ipfs://QmaKRLxXPdeTsLx7MFLS3CJbhpSbResgoeL4fCgHB1mTsF"
@@ -1228,7 +1228,7 @@
12281228
"multicall": "0xca11bde05977b3631167028862be2a173976ca11",
12291229
"rpc": [],
12301230
"explorer": {
1231-
"url": "https://basescan.org/"
1231+
"url": "https://basescan.org"
12321232
},
12331233
"start": 5022,
12341234
"logo": "ipfs://QmaxRoHpxZd8PqccAynherrMznMufG6sdmHZLihkECXmZv"
@@ -1261,7 +1261,7 @@
12611261
"multicall": "0xc454132B017b55b427f45078E335549A7124f5f7",
12621262
"rpc": [],
12631263
"explorer": {
1264-
"url": "https://agung-testnet.subscan.io/"
1264+
"url": "https://agung-testnet.subscan.io"
12651265
},
12661266
"start": 2031789,
12671267
"logo": "ipfs://bafkreidqkleori7pmilesz4t52iebebaqf3oflzmoz646qfuaznanb3sgm",
@@ -1309,7 +1309,7 @@
13091309
"multicall": "0x9BF49b704EE2A095b95c1f2D4EB9010510c41C9E",
13101310
"rpc": [],
13111311
"explorer": {
1312-
"url": "https://subnets-test.avax.network/beam/"
1312+
"url": "https://subnets-test.avax.network/beam"
13131313
},
13141314
"start": 3,
13151315
"logo": "ipfs://QmaKRLxXPdeTsLx7MFLS3CJbhpSbResgoeL4fCgHB1mTsF",
@@ -1415,7 +1415,7 @@
14151415
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
14161416
"rpc": [],
14171417
"explorer": {
1418-
"url": "https://apechain.calderaexplorer.xyz/"
1418+
"url": "https://apechain.calderaexplorer.xyz"
14191419
},
14201420
"start": 20889,
14211421
"logo": "ipfs://bafkreielbgcox2jsw3g6pqulqb7pyjgx7czjt6ahnibihaij6lozoy53w4"
@@ -1448,7 +1448,7 @@
14481448
"https://arbitrum-nova.public.blastapi.io"
14491449
],
14501450
"explorer": {
1451-
"url": "https://nova.arbiscan.io/"
1451+
"url": "https://nova.arbiscan.io"
14521452
},
14531453
"start": 6006607,
14541454
"logo": "ipfs://bafkreie5xsqt3mrrwu7v32qpmmctibhzhgxf4emfzzddsdhdlfsa7fmplu"
@@ -1514,7 +1514,7 @@
15141514
"https://rpc.rei.network"
15151515
],
15161516
"explorer": {
1517-
"url": "https://scan.rei.network/"
1517+
"url": "https://scan.rei.network"
15181518
},
15191519
"start": 1715902,
15201520
"logo": "ipfs://QmTogMDLmDgJjDjUKDHDuc2KVTVDbXf8bXJLFiVe8PRxgo"
@@ -1529,7 +1529,7 @@
15291529
"https://subnets.avax.network/defi-kingdoms/dfk-chain/rpc"
15301530
],
15311531
"explorer": {
1532-
"url": "https://subnets.avax.network/defi-kingdoms/"
1532+
"url": "https://subnets.avax.network/defi-kingdoms"
15331533
},
15341534
"start": 62,
15351535
"logo": "ipfs://QmZNkpVgPbuVbDcsi6arwH1om3456FGnwfDqYQJWUfHDEx"
@@ -1558,7 +1558,7 @@
15581558
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
15591559
"rpc": [],
15601560
"explorer": {
1561-
"url": "https://sepolia.lineascan.build/"
1561+
"url": "https://sepolia.lineascan.build"
15621562
},
15631563
"start": 227427,
15641564
"logo": "ipfs://bafkreihtyzolub3sejuwc32hpdpjnt7ksowaguni2yuho3kyihhcqrtqce",
@@ -1573,7 +1573,7 @@
15731573
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
15741574
"rpc": [],
15751575
"explorer": {
1576-
"url": "https://lineascan.build/"
1576+
"url": "https://lineascan.build"
15771577
},
15781578
"start": 42,
15791579
"logo": "ipfs://bafkreihtyzolub3sejuwc32hpdpjnt7ksowaguni2yuho3kyihhcqrtqce"
@@ -1608,7 +1608,7 @@
16081608
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
16091609
"rpc": [],
16101610
"explorer": {
1611-
"url": "https://amoy.polygonscan.com/"
1611+
"url": "https://amoy.polygonscan.com"
16121612
},
16131613
"start": 3127388,
16141614
"logo": "ipfs://bafkreibfiyvhqnme2vbxxfcku7qkxgjpkg6ywdkplxh4oxlkqsbznyorfm",
@@ -1637,7 +1637,7 @@
16371637
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
16381638
"rpc": [],
16391639
"explorer": {
1640-
"url": "https://base-sepolia.blockscout.com/"
1640+
"url": "https://base-sepolia.blockscout.com"
16411641
},
16421642
"start": 1059647,
16431643
"logo": "ipfs://QmaxRoHpxZd8PqccAynherrMznMufG6sdmHZLihkECXmZv",
@@ -1696,7 +1696,7 @@
16961696
"multicall": "0x97148F8fDdd9A1620f72EC1Bb2932916623d9da5",
16971697
"rpc": [],
16981698
"explorer": {
1699-
"url": "https://sepolia.explorer.zklink.io/"
1699+
"url": "https://sepolia.explorer.zklink.io"
17001700
},
17011701
"start": 43723,
17021702
"logo": "ipfs://bafkreic6c3iems5235qapyhyrygha7akqrsfact2nok3y2uhljpzxrdu74",
@@ -1749,7 +1749,7 @@
17491749
"multicall": "0xffc391F0018269d4758AEA1a144772E8FB99545E",
17501750
"rpc": [],
17511751
"explorer": {
1752-
"url": "https://testnet.cyberscan.co/"
1752+
"url": "https://testnet.cyberscan.co"
17531753
},
17541754
"start": 304545,
17551755
"logo": "ipfs://bafkreifm2bbehoqpz4454o7gixnxfi6cgvqlxigqr3f6ipj7l2omtgfgnm",
@@ -1779,7 +1779,7 @@
17791779
"multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
17801780
"rpc": [],
17811781
"explorer": {
1782-
"url": "https://devnet.neonscan.org/"
1782+
"url": "https://devnet.neonscan.org"
17831783
},
17841784
"start": 205206112,
17851785
"logo": "ipfs://QmecRPQGa4bU7tybg1sUQY48Md9rWnmhrT6WW5ueqvhg6P",
@@ -1840,4 +1840,4 @@
18401840
"start": 7521509,
18411841
"logo": "ipfs://QmNnGPr1CNvj12SSGzKARtUHv9FyEfE5nES73U4vBWQSJL"
18421842
}
1843-
}
1843+
}

‎test/e2e/network.spec.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import networks from '../../src/networks.json';
2+
import { test, expect, describe } from 'vitest';
3+
4+
describe('test networks.json file', () => {
5+
test('explorer endpoint should not end with a /', () => {
6+
expect(
7+
Object.values(networks).every(
8+
(network) => !network.explorer.url.endsWith('/')
9+
)
10+
).toBe(true);
11+
});
12+
});

0 commit comments

Comments
 (0)