Skip to content

Commit 29b30bb

Browse files
authored
Revert "Make keepdims to its default value when adding ReduceMin/ReduceMax for quantization calibration (microsoft#6788)" (microsoft#6825)
This reverts commit 9b3171e.
1 parent 4bbea91 commit 29b30bb

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

onnxruntime/python/tools/quantization/calibrate.py

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import numpy as np
1111
import onnx
1212
import onnxruntime
13-
from onnx import helper, TensorProto, ModelProto, shape_inference
13+
from onnx import helper, TensorProto, ModelProto
1414
from onnx import onnx_pb as onnx_proto
1515
from six import string_types
1616
from enum import Enum
@@ -52,9 +52,6 @@ def __init__(self, model, op_types_to_calibrate=[], augmented_model_path='augmen
5252
else:
5353
raise ValueError('model should be either model path or onnx.ModelProto.')
5454

55-
# Apply shape inference on the model
56-
self.model = onnx.shape_inference.infer_shapes(self.model)
57-
5855
self.op_types_to_calibrate = op_types_to_calibrate
5956
self.augmented_model_path = augmented_model_path
6057

@@ -163,27 +160,26 @@ def augment_graph(self):
163160

164161
added_nodes = []
165162
added_outputs = []
166-
tensors, value_infos = self.select_tensors_to_calibrate(model)
163+
tensors, _ = self.select_tensors_to_calibrate(model)
167164

168165
for tensor in tensors:
169-
170-
# Get tensor's shape
171-
dim = len(value_infos[tensor].type.tensor_type.shape.dim)
172-
shape = (1,) if dim == 1 else list(1 for i in range(dim))
173-
174166
# Adding ReduceMin nodes
175167
reduce_min_name = tensor + '_ReduceMin'
176-
reduce_min_node = onnx.helper.make_node('ReduceMin', [tensor], [tensor + '_ReduceMin'], reduce_min_name)
168+
reduce_min_node = onnx.helper.make_node('ReduceMin', [tensor], [tensor + '_ReduceMin'],
169+
reduce_min_name,
170+
keepdims=0)
177171

178172
added_nodes.append(reduce_min_node)
179-
added_outputs.append(helper.make_tensor_value_info(reduce_min_node.output[0], TensorProto.FLOAT, shape))
173+
added_outputs.append(helper.make_tensor_value_info(reduce_min_node.output[0], TensorProto.FLOAT, ()))
180174

181175
# Adding ReduceMax nodes
182176
reduce_max_name = tensor + '_ReduceMax'
183-
reduce_max_node = onnx.helper.make_node('ReduceMax', [tensor], [tensor + '_ReduceMax'], reduce_max_name)
177+
reduce_max_node = onnx.helper.make_node('ReduceMax', [tensor], [tensor + '_ReduceMax'],
178+
reduce_max_name,
179+
keepdims=0)
184180

185181
added_nodes.append(reduce_max_node)
186-
added_outputs.append(helper.make_tensor_value_info(reduce_max_node.output[0], TensorProto.FLOAT, shape))
182+
added_outputs.append(helper.make_tensor_value_info(reduce_max_node.output[0], TensorProto.FLOAT, ()))
187183

188184
model.graph.node.extend(added_nodes)
189185
model.graph.output.extend(added_outputs)

0 commit comments

Comments
 (0)