Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Support to define the name of the REGISTRY (e.g: *.local) #301

Closed
cmoulliard opened this issue May 2, 2023 · 0 comments · Fixed by #298
Closed

[improvement] Support to define the name of the REGISTRY (e.g: *.local) #301

cmoulliard opened this issue May 2, 2023 · 0 comments · Fixed by #298
Assignees
Labels
enhancement New feature or request module::kind

Comments

@cmoulliard
Copy link
Member

cmoulliard commented May 2, 2023

Improvement

Suggestion: Been able to set the value of the variable REGISTRY_NAME (e.g: kind-registry.local).

Motivation: Some libs like go-containerregistry only supports to make HTTP requests to an internal private registry when the name of the registry is defined as *.local* (See this example: https://github.com/traPtitech/NeoShowcase/commit/db5ad3f83b3cb8471fb46ddf812322da1b3e425b). Having this option will allow to use Paketo buildpack with a docker registry when it runs as a pod as it uses under the hood google/go-containerregistry`

Related to: buildpacks/lifecycle#524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module::kind
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants