Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Document Type #104

Open
szareiangm opened this issue Jul 4, 2018 · 5 comments
Open

Remove Document Type #104

szareiangm opened this issue Jul 4, 2018 · 5 comments

Comments

@szareiangm
Copy link
Contributor

It is getting deprecated in ES 7. We can leave it as a setting in final step and remove it from the rest code to minimize the impact

@BenFradet
Copy link
Contributor

We can leave it as a setting in final step and remove it from the rest code to minimize the impact

mmh if we're removing it from the code we should remove it from the configuration too

@szareiangm
Copy link
Contributor Author

yes but how about the backward compatibility with older Elasticsearch clusters?

@BenFradet
Copy link
Contributor

so let's keep it in 👍

@szareiangm
Copy link
Contributor Author

sure. let's keep it until we see how ES 7 client would be behave against older versions. cheers!

@szareiangm szareiangm reopened this Jul 4, 2018
@BenFradet
Copy link
Contributor

yup let's leave this open until we decide to actually make the change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants