Skip to content

Commit 434bb75

Browse files
committed
Remove duration from media tests and don't run vimeo tests
1 parent 6882079 commit 434bb75

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

trackers/javascript-tracker/test/media/media.test.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ const makeExpectedEvent = (
7272
schema: 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/1-0-0',
7373
data: {
7474
currentTime: jasmine.any(Number),
75-
duration: 20,
7675
ended: false,
7776
loop: false,
7877
muted: true,
@@ -224,10 +223,10 @@ describe('Media Tracking', () => {
224223

225224
const expected = {
226225
ready: {
227-
mediaPlayer: { paused: true, duration: jasmine.any(Number) },
226+
mediaPlayer: { paused: true },
228227
videoElement: { videoHeight: jasmine.any(Number), videoWidth: jasmine.any(Number) },
229228
},
230-
play: {},
229+
play: { mediaPlayer: { duration: 20 } },
231230
pause: { mediaPlayer: { paused: true } },
232231
volumechange: { mediaPlayer: { paused: true, volume: 50 } },
233232
ratechange: { mediaPlayer: { paused: true, volume: 50, playbackRate: 0.9 } },
@@ -481,7 +480,6 @@ describe('Media Tracking', () => {
481480
error: jasmine.any(Object),
482481
},
483482
mediaPlayer: {
484-
duration: 0,
485483
paused: true,
486484
},
487485
videoElement: {
@@ -496,7 +494,6 @@ describe('Media Tracking', () => {
496494
mediaPlayer: {
497495
currentTime: 0,
498496
paused: true,
499-
duration: 0,
500497
},
501498
videoElement: {
502499
videoHeight: 0,

trackers/javascript-tracker/test/wdio.default.conf.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@ function getFullPath(path: string): string {
99
type CustomTestRunnerConfig = Options.Testrunner & { dockerInstance?: DockerWrapper };
1010

1111
export const config: Omit<Options.Testrunner, 'capabilities'> = {
12-
specs: [[getFullPath('test/functional/*.test.ts'), getFullPath('test/integration/*.test.ts')]],
12+
specs: [[
13+
getFullPath('test/functional/*.test.ts'),
14+
getFullPath('test/integration/*.test.ts'),
15+
getFullPath('test/media/media.test.ts'),
16+
getFullPath('test/media/youtube.test.ts'),
17+
]],
1318
logLevel: 'warn',
1419
baseUrl: 'http://snowplow-js-tracker.local:8080',
1520
waitforTimeout: 30000,

0 commit comments

Comments
 (0)