chore(tests): fix test assertion (#126)

j-luong · web-flow · commit d41a2bdcae17 · 2025-09-30T17:26:50.000+01:00
diff --git a/internal/analysis/analysis_test.go b/internal/analysis/analysis_test.go
@@ -174,11 +174,8 @@ func validateTestRequestBody(t *testing.T, request io.Reader) {
 	bundle, err := testRequestBody.Data.Attributes.Input.AsTestInputSourceBundle()
 	assert.NoError(t, err)
 
-	if bundle.Metadata.CommitId != nil {
-		assert.Regexp(t, "^[0-9a-f]{40}$", *bundle.Metadata.CommitId)
-	}
-	if bundle.Metadata.RepoUrl != nil {
-		assert.Regexp(t, "^git@github.com:[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+.git$", *bundle.Metadata.RepoUrl)
+	if bundle.Metadata.CommitId != nil || bundle.Metadata.RepoUrl != nil {
+		assert.NotEqual(t, *bundle.Metadata.RepoUrl, *bundle.Metadata.CommitId)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -174,11 +174,8 @@ func validateTestRequestBody(t *testing.T, request io.Reader) {`
`174`	`174`	`bundle, err := testRequestBody.Data.Attributes.Input.AsTestInputSourceBundle()`
`175`	`175`	`assert.NoError(t, err)`
`176`	`176`
`177`		`- if bundle.Metadata.CommitId != nil {`
`178`		`- assert.Regexp(t, "^[0-9a-f]{40}$", *bundle.Metadata.CommitId)`
`179`		`- }`
`180`		`- if bundle.Metadata.RepoUrl != nil {`
`181`		`- assert.Regexp(t, "^[email protected]:[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+.git$", *bundle.Metadata.RepoUrl)`
	`177`	`+ if bundle.Metadata.CommitId != nil \|\| bundle.Metadata.RepoUrl != nil {`
	`178`	`+ assert.NotEqual(t, bundle.Metadata.RepoUrl, bundle.Metadata.CommitId)`
`182`	`179`	`}`
`183`	`180`	`}`
`184`	`181`