Skip to content

Commit 7bfcf91

Browse files
bastiandoetschbastiandoetsch
authored
fix: remove target="_blank" from html sources [IDE-677] (#683)
1 parent 6bbcc14 commit 7bfcf91

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

‎infrastructure/code/template/details.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ <h2 class="severity-title">{{.IssueTitle}}</h2>
719719
{{if gt (len .CWEs) 0}}
720720
<span class="delimiter">|</span>
721721
{{range $index, $cwe := .CWEs}}
722-
<a class="cwe styled-link" target="_blank" rel="noopener noreferrer"
722+
<a class="cwe styled-link" rel="noopener noreferrer"
723723
href="https://cwe.mitre.org/data/definitions/{{trimCWEPrefix $cwe}}.html">{{$cwe}}</a>
724724
{{if ne $index (idxMinusOne (len $.CWEs))}}<span class="delimiter"></span>{{end}}
725725
{{end}}
@@ -739,7 +739,7 @@ <h2 class="severity-title">{{.IssueTitle}}</h2>
739739
<div class="lesson-icon">
740740
{{.LessonIcon}}
741741
</div>
742-
<a class="lesson-link styled-link is-external" target="_blank" rel="noopener noreferrer" href="{{.LessonUrl}}">
742+
<a class="lesson-link styled-link is-external" rel="noopener noreferrer" href="{{.LessonUrl}}">
743743
Learn about this vulnerability
744744
{{.ExternalIcon}}
745745
</a>
@@ -782,7 +782,7 @@ <h2 class="severity-title">{{.IssueTitle}}</h2>
782782
<div class="ignore-next-step-text">
783783
Ignores are currently managed in the Snyk web app.
784784
To edit or remove the ignore please go to:
785-
<a class="styled-link" href="{{.SnykWebUrl}}" target="_blank"
785+
<a class="styled-link" href="{{.SnykWebUrl}}"
786786
rel="noopener noreferrer">{{.SnykWebUrl}}</a>.
787787
</div>
788788
</div>
@@ -938,7 +938,7 @@ <h2 class="example-fixes-header">Fixed Code Examples</h2>
938938
<div id="current-example" class="repo clickable">
939939
{{.GitHubIcon}}
940940
<span id="example-link" class="example-repo-link">
941-
<a id="example-repo-anchor" href="{{(index .ExampleCommitFixes 0).RepoLink}}" target="_blank"
941+
<a id="example-repo-anchor" href="{{(index .ExampleCommitFixes 0).RepoLink}}"
942942
rel="noopener noreferrer">
943943
{{(index .ExampleCommitFixes 0).RepoName}}
944944
</a>

‎infrastructure/iac/iac_html_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ func Test_IaC_Html_getIacHtml(t *testing.T) {
3838
assert.Contains(t, iacPanelHtml, `<div class="severity-container">`, "HTML should contain the severity icon container")
3939

4040
// Reference section
41-
assert.Contains(t, iacPanelHtml, `<a class="styled-link" target="_blank" rel="noopener noreferrer" href="https://kubernetes.io/docs/reference/access-authn-authz/rbac/">https://kubernetes.io/docs/reference/access-authn-authz/rbac/</a>`, "HTML should contain the first reference")
42-
assert.Contains(t, iacPanelHtml, `<a class="styled-link" target="_blank" rel="noopener noreferrer" href="https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole">https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole</a>`, "HTML should contain the second reference")
41+
assert.Contains(t, iacPanelHtml, `<a class="styled-link" rel="noopener noreferrer" href="https://kubernetes.io/docs/reference/access-authn-authz/rbac/">https://kubernetes.io/docs/reference/access-authn-authz/rbac/</a>`, "HTML should contain the first reference")
42+
assert.Contains(t, iacPanelHtml, `<a class="styled-link" rel="noopener noreferrer" href="https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole">https://kubernetes.io/docs/reference/access-authn-authz/rbac/#role-and-clusterrole</a>`, "HTML should contain the second reference")
4343
}
4444

4545
func createIacIssueSample() snyk.Issue {

‎infrastructure/iac/template/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ <h2 class="severity-title">{{.Issue.AdditionalData.Title}}</h2>
4545
<div class="severity-type-container">
4646
<div class="severity-type">Issue</div>
4747
<span class="delimiter"></span>
48-
<a class="styled-link" target="_blank" rel="noopener noreferrer"
48+
<a class="styled-link" rel="noopener noreferrer"
4949
href="{{.Issue.AdditionalData.Documentation}}">{{.Issue.ID}}</a>
5050
</header>
5151
<section class="delimiter-top summary">
@@ -78,7 +78,7 @@ <h2>Remediation</h2>
7878
<h2>References</h2>
7979
<div class="summary-items">
8080
{{range .Issue.AdditionalData.References}}
81-
<a class="styled-link" target="_blank" rel="noopener noreferrer" href="{{.}}">{{.}}</a>
81+
<a class="styled-link" rel="noopener noreferrer" href="{{.}}">{{.}}</a>
8282
{{end}}
8383
</div>
8484
</section>

‎infrastructure/oss/template/details.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
{{if gt (len .CVEs) 0}}
176176
<span class="delimiter"> </span>
177177
{{range $index, $cve := .CVEs}}
178-
<a class="cve styled-link" target="_blank" rel="noopener noreferrer"
178+
<a class="cve styled-link" rel="noopener noreferrer"
179179
href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=$cve">{{$cve}}</a>
180180
{{if ne $index (idxMinusOne (len $.CVEs))}}<span class="delimiter"></span>{{end}}
181181
{{end}}
@@ -184,19 +184,19 @@
184184
{{if gt (len .CWEs) 0}}
185185
<span class="delimiter"> </span>
186186
{{range $index, $cwe := .CWEs}}
187-
<a class="cwe styled-link" target="_blank" rel="noopener noreferrer"
187+
<a class="cwe styled-link" rel="noopener noreferrer"
188188
href="https://cwe.mitre.org/data/definitions/{{trimCWEPrefix $cwe}}.html">{{$cwe}}</a>
189189
{{if ne $index (idxMinusOne (len $.CWEs))}}<span class="delimiter"></span>{{end}}
190190
{{end}}
191191
{{end}}
192192

193193
{{if gt (len .CvssScore) 0}}
194194
<span class="delimiter"> </span>
195-
<a class="cvssscore styled-link" target="_blank" rel="noopener noreferrer" href="https://www.first.org/cvss/calculator/3.1#{{.CVSSv3}}">CVSS {{.CvssScore}}</a>
195+
<a class="cvssscore styled-link" rel="noopener noreferrer" href="https://www.first.org/cvss/calculator/3.1#{{.CVSSv3}}">CVSS {{.CvssScore}}</a>
196196
{{end}}
197197

198198
<span class="delimiter"> </span>
199-
<a class="styled-link" target="_blank" rel="noopener noreferrer"
199+
<a class="styled-link" rel="noopener noreferrer"
200200
href="https://snyk.io/vuln/{{.IssueId}}">{{.IssueId}}</a>
201201
</div>
202202
{{ if .LessonUrl }}

0 commit comments

Comments
 (0)