Skip to content

Fixing Windows builds when using target_link_libraries() #10

Description

@nickelpro

The current cmake configuration for ztd.idk is not header-only, it produces a library from the files in the source directory.

This is a problem, because the API linkage flag that api.h expects to see (ZTD_DLL) isn't set by the build system, so the library is built without exporting any symbols. This makes the library unlinkable on Windows.

This is all fixable, but I need to know the intent. The docs refer to idk as header only and it appears to work entirely in header-only mode. So should we just not compile these files? Should we create two targets, one for header only and one that compiles and links the library correctly?

Once I know what the intent is I can handle fixing up the cmake stuff.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions