Skip to content

Commit fd9dd74

Browse files
docs: use "connection" instead of "connect"
"connect" and "connection" have the same meaning, but "connection" is the preferred version.
1 parent c332643 commit fd9dd74

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

CHANGELOG.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -855,7 +855,7 @@ new Server(3000, {
855855
const socket = io("/admin");
856856

857857
// server-side
858-
io.on("connect", socket => {
858+
io.on("connection", socket => {
859859
// not triggered anymore
860860
})
861861

@@ -1006,7 +1006,7 @@ new Server(3000, {
10061006
const socket = io("/admin");
10071007

10081008
// server-side
1009-
io.on("connect", socket => {
1009+
io.on("connection", socket => {
10101010
// not triggered anymore
10111011
})
10121012

examples/angular-todomvc/server.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ interface Todo {
1515

1616
let todos: Array<Todo> = [];
1717

18-
io.on("connect", (socket) => {
18+
io.on("connection", (socket) => {
1919
socket.emit("todos", todos);
2020

2121
// note: we could also create a CRUD (create/read/update/delete) service for the todo list

examples/es-modules/server.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Server } from "socket.io";
22

33
const io = new Server(8080);
44

5-
io.on("connect", (socket) => {
5+
io.on("connection", (socket) => {
66
console.log(`connect ${socket.id}`);
77

88
socket.on("ping", (cb) => {

examples/express-session-example/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ io.engine.on("initial_headers", (headers, req) => {
6767
}
6868
});
6969

70-
io.on("connect", (socket) => {
70+
io.on("connection", (socket) => {
7171
const req = socket.request;
7272

7373
socket.join(req.session.id);

examples/typescript/server.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Server } from "socket.io";
22

33
const io = new Server(8080);
44

5-
io.on("connect", (socket) => {
5+
io.on("connection", (socket) => {
66
console.log(`connect ${socket.id}`);
77

88
socket.on("ping", (cb) => {

test/namespaces.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ describe("namespaces", () => {
6262
const io = new Server(0);
6363
const clientSocket = createClient(io);
6464

65-
io.on("connect", (socket) => {
65+
io.on("connection", (socket) => {
6666
expect(socket).to.be.a(Socket);
6767
success(done, io, clientSocket);
6868
});

test/socket.io.test-d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ describe("server", () => {
2424
expectType<DisconnectReason>(reason);
2525
});
2626
});
27-
sio.on("connect", (s) => {
27+
sio.on("connection", (s) => {
2828
expectType<Socket<DefaultEventsMap, DefaultEventsMap>>(s);
2929
});
3030
done();

0 commit comments

Comments
 (0)