Skip to content

Commit c18a7c4

Browse files
committed
Fix @pool.busy -> @pool.wait race condition/hang.
1 parent ce801f4 commit c18a7c4

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

async-http.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.required_ruby_version = ">= 3.2"
2626

2727
spec.add_dependency "async", ">= 2.10.2"
28-
spec.add_dependency "async-pool", "~> 0.9"
28+
spec.add_dependency "async-pool", "~> 0.11"
2929
spec.add_dependency "io-endpoint", "~> 0.14"
3030
spec.add_dependency "io-stream", "~> 0.6"
3131
spec.add_dependency "metrics", "~> 0.12"

lib/async/http/client.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,8 @@ def self.open(*arguments, **options, &block)
8080
end
8181

8282
def close
83-
while @pool.busy?
83+
@pool.wait_until_free do
8484
Console.warn(self) {"Waiting for #{@protocol} pool to drain: #{@pool}"}
85-
@pool.wait
8685
end
8786

8887
@pool.close

0 commit comments

Comments
 (0)