Restore 100% coverage and expose trace provider.

Author: ioquatix

config/sus.rb

@@ -5,3 +5,17 @@
 
 require "covered/sus"
 include Covered::Sus
+
+ENV["TRACES_BACKEND"] ||= "traces/backend/test"
+ENV["METRICS_BACKEND"] ||= "metrics/backend/test"
+
+def prepare_instrumentation!
+	require "traces"
+	require "metrics"
+end
+
+def before_tests(...)
+	prepare_instrumentation!
+	
+	super
+end

config/traces.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+# Released under the MIT License.
+# Copyright, 2024, by Samuel Williams.
+
+def prepare
+	require "traces/provider/protocol/http2"
+end

gems.rb

@@ -20,6 +20,9 @@
 	gem "decode"
 	gem "rubocop"
 
+	gem "traces"
+	gem "metrics"
+	
 	gem "bake-test"
 	gem "bake-test-external"
 end

lib/protocol/http2/framer.rb

@@ -16,8 +16,6 @@
 require_relative "window_update_frame"
 require_relative "continuation_frame"
 
-require "traces/provider"
-
 module Protocol
 	module HTTP2
 		# HTTP/2 frame type mapping as defined by the spec
@@ -109,50 +107,6 @@ def read_header
 
 				raise EOFError, "Could not read frame header!"
 			end
-			
-			Traces::Provider(self) do
-				def write_connection_preface
-					Traces.trace("protocol.http2.framer.write_connection_preface") do
-						super
-					end
-				end
-				
-				def read_connection_preface
-					Traces.trace("protocol.http2.framer.read_connection_preface") do
-						super
-					end
-				end
-				
-				def write_frame(frame)
-					attributes = {
-						"frame.length" => frame.length,
-						"frame.type" => frame.type,
-						"frame.flags" => frame.flags,
-						"frame.stream_id" => frame.stream_id,
-					}
-					
-					Traces.trace("protocol.http2.framer.write_frame", attributes: attributes) do
-						super
-					end
-				end
-				
-				def read_frame(maximum_frame_size = MAXIMUM_ALLOWED_FRAME_SIZE)
-					Traces.trace("protocol.http2.framer.read_frame") do |span|
-						super.tap do |frame|
-							span["frame.length"] = frame.length
-							span["frame.type"] = frame.type
-							span["frame.flags"] = frame.flags
-							span["frame.stream_id"] = frame.stream_id
-						end
-					end
-				end
-				
-				def flush
-					Traces.trace("protocol.http2.framer.flush") do
-						super
-					end
-				end
-			end
 		end
 	end
 end

lib/traces/provider/protocol/http2.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+# Released under the MIT License.
+# Copyright, 2024, by Samuel Williams.
+
+require_relative "http2/framer"

lib/traces/provider/protocol/http2/framer.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+# Released under the MIT License.
+# Copyright, 2024, by Samuel Williams.
+
+require "traces/provider"
+require_relative "../../../../protocol/http2/framer"
+
+Traces::Provider(Protocol::HTTP2::Framer) do
+	def write_connection_preface
+		Traces.trace("protocol.http2.framer.write_connection_preface") do
+			super
+		end
+	end
+	
+	def read_connection_preface
+		Traces.trace("protocol.http2.framer.read_connection_preface") do
+			super
+		end
+	end
+	
+	def write_frame(frame)
+		attributes = {
+			"frame.length" => frame.length,
+			"frame.class" => frame.class.name,
+			"frame.type" => frame.type,
+			"frame.flags" => frame.flags,
+			"frame.stream_id" => frame.stream_id,
+		}
+		
+		Traces.trace("protocol.http2.framer.write_frame", attributes: attributes) do
+			super
+		end
+	end
+	
+	def read_frame(...)
+		Traces.trace("protocol.http2.framer.read_frame") do |span|
+			super.tap do |frame|
+				span["frame.length"] = frame.length
+				span["frame.type"] = frame.type
+				span["frame.flags"] = frame.flags
+				span["frame.stream_id"] = frame.stream_id
+			end
+		end
+	end
+	
+	def flush
+		Traces.trace("protocol.http2.framer.flush") do
+			super
+		end
+	end
+end