Another missing check for invalid taxids in majoritylca

milot-mirdita · milot-mirdita · commit 8d171379a01a · 2024-12-27T10:19:20.000+09:00
diff --git a/src/taxonomy/NcbiTaxonomy.cpp b/src/taxonomy/NcbiTaxonomy.cpp
@@ -707,6 +707,9 @@ WeightedTaxResult NcbiTaxonomy::weightedMajorityLCA(const std::vector<WeightedTa
             continue;
         }
         TaxonNode const *node = taxonNode(currTaxId, false);
+        if (node == NULL) {
+            continue;
+        }
 
         // iterate all ancestors up to the root
         TaxID currParentTaxId = node->parentTaxId;

Original file line number	Diff line number	Diff line change
`@@ -707,6 +707,9 @@ WeightedTaxResult NcbiTaxonomy::weightedMajorityLCA(const std::vector<WeightedTa`
`707`	`707`	`continue;`
`708`	`708`	`}`
`709`	`709`	`TaxonNode const *node = taxonNode(currTaxId, false);`
	`710`	`+ if (node == NULL) {`
	`711`	`+ continue;`
	`712`	`+ }`
`710`	`713`
`711`	`714`	`// iterate all ancestors up to the root`
`712`	`715`	`TaxID currParentTaxId = node->parentTaxId;`