Allow change accept header when wildcard accept header is requested (#8)

Co-authored-by: Jose Manuel Cardona <[email protected]>

Author: joskfg

composer.json

@@ -10,8 +10,8 @@
     },
     "require": {
         "php": ">=7.2",
-        "illuminate/http": "^7.0 || ^8.0 || ^9.0",
-        "illuminate/contracts": "^7.0 || ^8.0 || ^9.0"
+        "illuminate/http": "^8.0 || ^9.0 || ^10.0",
+        "illuminate/contracts": "^8.0 || ^9.0 || ^10.0"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^2.16",

src/Middleware/RequestAcceptJson.php

@@ -9,7 +9,9 @@ class RequestAcceptJson
 {
     public function handle(Request $request, Closure $next)
     {
-        if (!$request->headers->has('Accept')) {
+        $accept = $request->headers->get('Accept');
+
+        if ($accept === null || $accept === '*/*' || $accept === 'application/*') {
             $request->headers->set('Accept', 'application/json');
         }
 

tests/Middleware/RequestAcceptJsonTest.php

@@ -25,6 +25,40 @@ function ($request) {
         $this->assertSame('application/json', $result->header('Accept'));
     }
 
+    /**
+     * @test
+     */
+    public function whenItReceivesWildcardAcceptHeaderItShouldSetToApplicationJson()
+    {
+        $mockRequest = $this->getRequest(['Accept' => '*/*']);
+        $middleware  = new RequestAcceptJson();
+
+        $result = $middleware->handle(
+            $mockRequest,
+            function ($request) {
+                return $request;
+            }
+        );
+        $this->assertSame('application/json', $result->header('Accept'));
+    }
+
+    /**
+     * @test
+     */
+    public function whenItReceivesApplicationWildcardAcceptHeaderItShouldSetToApplicationJson()
+    {
+        $mockRequest = $this->getRequest(['Accept' => 'application/*']);
+        $middleware  = new RequestAcceptJson();
+
+        $result = $middleware->handle(
+            $mockRequest,
+            function ($request) {
+                return $request;
+            }
+        );
+        $this->assertSame('application/json', $result->header('Accept'));
+    }
+
     /**
      * @test
      */