-
-
Notifications
You must be signed in to change notification settings - Fork 605
Add support for iOS 26 subtitle in native stack #3200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very promising. I'll review #2987 first & jump into this one. I think we'll land it.
|
Nice work! After this is landed I think next step should be to add support for More info: |
|
You can also modify |
|
I reasoned on this as well while working on this PR. My personal opinion is that the most correct solution would be to turn largeTitle to string and make it work as it is supposed to, but this would break compatibility with older versions. A solution to don't break the api could be to make largeTitle |
|
Do you have any update on the expected arrival time? |
|
Hi @kkafar will you review this PR? |
|
Hey @kkafar, any progress here? |
Description
This PR adds support for new properties introduced in iOS 26 as subtitle and largeSubtitle
Changes
Screenshots / GIFs
Test code and steps to reproduce
Inside of
TestSubtitle.tsxyou can pass to the screen option these new options:Keep in mind that TypeScript will throw an error since the scope of this PR is just react-native-screens not react-navigation and the modification in the react-navigation submodule just aim to pass through the new props.
Checklist